From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Fri, 11 Mar 2005 18:15:36 +0200 Message-ID: <01c52655$Blat.v2.4$b47b9200@zahav.net.il> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1110558818 7342 80.91.229.2 (11 Mar 2005 16:33:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 11 Mar 2005 16:33:38 +0000 (UTC) Cc: hunterd42@comcast.net, emacs-devel@gnu.org, kobayays@otsukakj.co.jp, jasonr@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 11 17:33:37 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9mqT-0006kJ-Cc for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 17:18:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9n5Z-0007gB-C6 for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 11:34:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9n57-0007a5-A5 for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:33:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9n52-0007WU-26 for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:33:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9n51-0007WJ-Qc for emacs-devel@gnu.org; Fri, 11 Mar 2005 11:33:39 -0500 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D9mpp-0002tn-L8; Fri, 11 Mar 2005 11:17:57 -0500 Original-Received: from zaretski (tony02-27-42.inter.net.il [80.230.27.42]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id DXL11448 (AUTH halo1); Fri, 11 Mar 2005 18:17:53 +0200 (IST) Original-To: "Lennart Borgman" X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> (lennart.borgman.073@student.lu.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34480 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34480 > From: "Lennart Borgman" > Cc: , , > > Date: Fri, 11 Mar 2005 17:03:28 +0100 > > > HAVE_NTGUI is better than WINDOWSNT here, I think. > > I think it would be much more readable if we had a special define. Not in this case, IMHO; see below. > This was my suggestion earlier: > > > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I > > believe most would like better - but not I) replacing them with something > > like > > > > #ifdef HAS_HOURGLASS > > In the light of your answers I do not believe you want to remove these > ifdefs so I suggest now we do something like: > > #if HAVE_HOURGLASS This would require to have some configury stuff that would detect whether HAVE_HOURGLASS should be defined or not. Since Windows doesn't run the usual configure script (and neither does the DOS port), adding such a define will require more hacking in these ports. Especially since writing a test for this feature is not so easy even for those platforms which do support hourglass (e.g., think about Emacs configured with --without-x). So please don't do that. Please replace #ifdef HAVE_X_WINDOWS with #if defined(HAVE_X_WINDOWS) || defined(HAVE_NTGUI)