all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Eli Zaretskii" <eliz@gnu.org>
Cc: bob@rattlesnake.com, emacs-devel@gnu.org
Subject: Re: [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el
Date: Mon, 27 Dec 2004 10:00:40 +0200	[thread overview]
Message-ID: <01c4ebea$Blat.v2.2.2$4d937300@zahav.net.il> (raw)
In-Reply-To: <87ekhcsurb.fsf@jurta.org> (message from Juri Linkov on Sun, 26 Dec 2004 21:42:36 +0200)

> From: Juri Linkov <juri@jurta.org>
> Date: Sun, 26 Dec 2004 21:42:36 +0200
> Cc: emacs-devel@gnu.org
> 
> (defface escape-glyph '((((background dark)) :foreground "burlywood2")
> 			(((type pc)) :foreground "magenta")
> 			(t :foreground "dark green"))
>   "Face for characters displayed as ^-sequences or \\-sequences."
>   :group 'basic-faces)

Please don't use `(type pc)' in face definitions; we now have the
min-colors feature to express the same color selection in a more
device-independent way (e.g., it will also be right for a 16-color
xterm).

Also, I think "magenta" is a bad color choice for 16-color terminals,
as its definition in tty-colors.el will produce a color that is very
different from "burlywood2".  How about "brown" or "yellow" instead?

The 8-color terminals will also need a separate definition (yellow?):
"burlywood2" translates there to "green", believe it or not.

  reply	other threads:[~2004-12-27  8:00 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1CZoXW-0007hE-UW@lists.gnu.org>
     [not found] ` <E1Ca4Kt-00067g-EH@fencepost.gnu.org>
2004-12-03  9:18   ` [Emacs-trunk-diffs] Changes to emacs/lisp/faces.el Kim F. Storm
2004-12-04  2:48     ` Richard Stallman
2004-12-05 17:52       ` Juri Linkov
2004-12-05 18:32         ` Daniel Pfeiffer
2004-12-06  1:40         ` Richard Stallman
2004-12-07 22:40           ` Daniel Pfeiffer
2004-12-07 23:48             ` Stefan Monnier
2004-12-08  8:47               ` Daniel Pfeiffer
2004-12-08 15:16                 ` Stefan Monnier
2004-12-08 22:15               ` Richard Stallman
2004-12-08 22:15             ` Richard Stallman
2004-12-12  9:19               ` Daniel Pfeiffer
2004-12-13  9:03                 ` Juri Linkov
2004-12-13 14:51                   ` Stefan Monnier
2004-12-13 19:51                 ` Richard Stallman
2004-12-13 23:41                   ` Daniel Pfeiffer
2004-12-14 23:22                     ` Richard Stallman
2004-12-17  0:54                     ` Richard Stallman
2004-12-19  9:41                       ` Daniel Pfeiffer
2004-12-21 11:21                         ` Richard Stallman
2004-12-23 20:39                           ` Daniel Pfeiffer
2004-12-14 12:32                   ` Kim F. Storm
2004-12-15 10:56                     ` Juri Linkov
2004-12-15 11:21                       ` Kim F. Storm
2004-12-15 12:01                         ` Robert J. Chassell
2004-12-15 14:58                     ` Richard Stallman
2004-12-15 16:14                       ` Kim F. Storm
2004-12-15 20:35                         ` Daniel Pfeiffer
2004-12-24  2:28                       ` Juri Linkov
2004-12-24 13:26                         ` Robert J. Chassell
2004-12-26 19:42                           ` Juri Linkov
2004-12-27  8:00                             ` Eli Zaretskii [this message]
2004-12-27 19:53                               ` Juri Linkov
2004-12-27 22:01                                 ` Eli Zaretskii
2004-12-27 22:56                                   ` Stefan Monnier
2004-12-28 17:25                                     ` Richard Stallman
2004-12-28  2:38                                   ` Juri Linkov
2004-12-28  4:47                                     ` Eli Zaretskii
2004-12-28  7:52                                       ` Juri Linkov
2004-12-28 20:36                                         ` Eli Zaretskii
2004-12-29  0:22                                           ` Juri Linkov
2004-12-29  4:45                                             ` Eli Zaretskii
2004-12-30  7:33                                               ` Juri Linkov
2004-12-30 14:21                                                 ` Alex Schroeder
2004-12-30 16:33                                                   ` Drew Adams
2004-12-30 20:59                                                 ` Richard Stallman
2004-12-28  4:57                                   ` Richard Stallman
2004-12-25 15:12                         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01c4ebea$Blat.v2.2.2$4d937300@zahav.net.il' \
    --to=eliz@gnu.org \
    --cc=bob@rattlesnake.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.