From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: $USERPROFILE for $HOME on W32 Date: Fri, 26 Nov 2004 22:56:01 +0200 Message-ID: <01c4d3fa$Blat.v2.2.2$7bc7e880@zahav.net.il> References: <87vfbycsgj.fsf-monnier+emacs@gnu.org> <87mzx69bkn.fsf-monnier+emacs@gnu.org> <01c4d338$Blat.v2.2.2$34177b80@zahav.net.il> Reply-To: Eli Zaretskii NNTP-Posting-Host: deer.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1101502762 8845 80.91.229.6 (26 Nov 2004 20:59:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 26 Nov 2004 20:59:22 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 26 21:59:14 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CXnBS-000154-00 for ; Fri, 26 Nov 2004 21:59:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXnKi-0000Wn-LZ for ged-emacs-devel@m.gmane.org; Fri, 26 Nov 2004 16:08:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CXnKb-0000Wa-9n for emacs-devel@gnu.org; Fri, 26 Nov 2004 16:08:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CXnKa-0000WN-Kf for emacs-devel@gnu.org; Fri, 26 Nov 2004 16:08:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CXnKa-0000WK-Gs for emacs-devel@gnu.org; Fri, 26 Nov 2004 16:08:40 -0500 Original-Received: from [192.114.186.15] (helo=balder.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CXnBE-0008Ci-Ew; Fri, 26 Nov 2004 15:59:00 -0500 Original-Received: from zaretski ([80.230.149.126]) by balder.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id DWO25121 (AUTH halo1); Fri, 26 Nov 2004 22:58:56 +0200 (IST) Original-To: monnier@iro.umontreal.ca, jasonr@gnu.org, emacs-devel@gnu.org X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 2.2.2 In-reply-to: <01c4d338$Blat.v2.2.2$34177b80@zahav.net.il> (eliz@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30404 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30404 > Date: Thu, 25 Nov 2004 23:45:18 +0200 > From: "Eli Zaretskii" > Cc: jasonr@gnu.org, emacs-devel@gnu.org > > > From: Stefan > > Date: Thu, 25 Nov 2004 12:45:48 -0500 > > Cc: emacs-devel@gnu.org, Jason Rumney > > > > >> + /* Set dir and shell from environment variables. */ > > >> + strcpy (the_passwd.pw_dir, getenv ("HOME")); > > > > > What if strlen (getenv ("HOME")) >= sizeof (the_passwd.pw_dir)? > > > > Well, tough! > > This code is not new: it's just moved from one place to another so it's not > > a new problem. > > Can you (or someone else) look at the w32 system headers and see how > struct passwd is defined there? Silly me: it's defined on w32.c, right there. The pw_dir etc. struct members are defined as fixed-size strings, and the sizes are all 256 bytes, including the terminating null. So I think, at least that should be changed to 261, since the longest file name supported by Windows is 260 characters.