* bug#4114: marked as done (23.1; face doc unclear - no explanation of "underlying" face or attribute value)
2009-08-11 5:12 ` bug#4114: 23.1; face doc unclear - no explanation of "underlying" face or attribute value Drew Adams
@ 2009-08-15 21:20 ` Emacs bug Tracking System
0 siblings, 0 replies; 3+ messages in thread
From: Emacs bug Tracking System @ 2009-08-15 21:20 UTC (permalink / raw)
To: Chong Yidong
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
Your message dated Sat, 15 Aug 2009 17:15:52 -0400
with message-id <87k514n5h3.fsf@cyd.mit.edu>
and subject line Re: 23.1; face doc unclear - no explanation of "underlying" face or attribute value
has caused the Emacs bug report #4114,
regarding 23.1; face doc unclear - no explanation of "underlying" face or attribute value
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
4114: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4114
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 4715 bytes --]
From: "Drew Adams" <drew.adams@oracle.com>
To: <bug-gnu-emacs@gnu.org>
Subject: 23.1; face doc unclear - no explanation of "underlying" face or attribute value
Date: Mon, 10 Aug 2009 22:12:01 -0700
Message-ID: <01BB332A01B1434DB2186E220990CFEB@us.oracle.com>
emacs -Q
In (elisp)Face Attributes, things are explained in terms of
"underlying" face. But this notion is never introduced or
explained. Consequently, the descriptions that refer to this are
incomprehensible. This includes the description of :height and
:inherit:
`:height'
Font height--either an integer in units of 1/10 point, or a
floating point number specifying the amount by which to scale the
height of any underlying face, or a function...
`:inherit'
The name of a face from which to inherit attributes, or a list of
face names. Attributes from inherited faces are merged into the
face like an underlying face would be, with higher priority than
underlying faces....
Incomprehensible.
Similarly, in (elisp)Attribute Functions, "underlying value" is used
with no definition/explanation, making the explanation of
`merge-face-attribute' incomprehensible:
Function: merge-face-attribute attribute value1 value2
If VALUE1 is a relative value for the face attribute ATTRIBUTE,
returns it merged with the underlying value VALUE2; otherwise,...
Huh? Is "underlying" simply an extra word here (so that it should be
removed), or does it really say something about VALUE2 (what)?
I have no idea what was intended in any of these passages. FWIW, no
such language appears anywhere in the Emacs 20 Elisp manual - is an
underlying face or attribute value something new since Emacs 20? If
so, define it so you can then use it to explain other things. If not,
please clarify what is meant in these passages.
Perhaps this use of "underlying" is a translation from some other
language? In any case, there is no explanation of what is meant.
When you are defining face A, what is its "underlying" face (or
faces)?
In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'
[-- Attachment #3: Type: message/rfc822, Size: 1840 bytes --]
From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 4114-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1; face doc unclear - no explanation of "underlying" face or attribute value
Date: Sat, 15 Aug 2009 17:15:52 -0400
Message-ID: <87k514n5h3.fsf@cyd.mit.edu>
> In (elisp)Face Attributes, things are explained in terms of
> "underlying" face. But this notion is never introduced or explained.
Thanks, I've tweaked the text and added a reference to the node
Displaying Faces, where the concept is explained.
> I have no idea what was intended in any of these passages.
Here's an experiment that should make this clear. Go to the default
*scratch* buffer and evaluate the following lines, one at a time:
;; Give the comments in this buffer a height of 15.
(set-face-attribute 'font-lock-comment-face nil :height 150)
;; Give characters 5 to 8 a height that's 0.9 times that of the
;; underlying face, in this case font-lock-comment-face.
(setq ov (make-overlay 5 8))
(overlay-put ov 'face (list :height 0.9))
^ permalink raw reply [flat|nested] 3+ messages in thread