all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mikhail Titov" <mlt@gmx.us>
To: 'Eric Schulte' <eric.schulte@gmx.com>, 'Achim Gratz' <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [babel, patch] ob-octave does not catch EOE from matlabShell on MS Windows
Date: Wed, 30 May 2012 10:58:15 -0500	[thread overview]
Message-ID: <019b01cd3e7d$06cf3790$146da6b0$@us> (raw)
In-Reply-To: <87396kmaf8.fsf@Rainer.invalid>

> -----Original Message-----
> From: emacs-orgmode-bounces+mlt=gmx.us@gnu.org [mailto:emacs-orgmode-
> bounces+mlt=gmx.us@gnu.org] On Behalf Of Achim Gratz
> Sent: Monday, May 28, 2012 1:24 PM
> To: emacs-orgmode@gnu.org
> Subject: Re: [O] [babel, patch] ob-octave does not catch EOE from
matlabShell
> on MS Windows
> 
> Eric Schulte writes:
> > Thanks for sending along the patch and the variable re-definition.  If I
> > understand correctly then the patch should be applied for any system,
> > but the variable definition need only be applied on windows systems.  Is
> > that correct?
> 
> The variable re-definition seems to be be needed for matlab-shell, I
> don't know if that would be restricted to Windows.
> 
> > Can anyone confirm that matlab/octave code blocks are still functional
> > on a GNU/Linux machine after the above patch and redefinition have been
> > applied?  I do not use octave/matlab myself and can't verify this.
> 
> The octave tests still pass on openSUSE with the patch applied along
> with all the other tests (except R, since I'm missing ESS).

I wonder how it still passes the test...

I think my patch unintentionally breaks octave. It probably should have been
just

			 org-babel-octave-eoe-output

instead of

		     (if matlabp
			 org-babel-octave-eoe-output
		       org-babel-octave-eoe-indicator) 

or other way around.

I apologize for bringing it all over to the list as I'm not proficient in
elisp yet.

I feel like ob-octave needs an overhaul in general as it does not respect
many header arguments like :width, :height, and graphics format (always
png). Also it would be nice if it removed extra prompts left in results as
does ob-R.el .

I'll post improved patch once I feel it is ready.

Eric, so for now, just hold on with the application of what I've sent.

Mikhail

  reply	other threads:[~2012-05-30 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 21:02 [babel] ob-octave does not catch EOE from matlabShell on MS Windows Mikhail Titov
2012-05-24 21:30 ` Mikhail Titov
2012-05-25 16:31   ` Mikhail Titov
2012-05-25 16:52     ` [babel, patch] " Mikhail Titov
2012-05-28 15:56       ` Eric Schulte
2012-05-28 18:23         ` Achim Gratz
2012-05-30 15:58           ` Mikhail Titov [this message]
2012-05-30 16:05             ` Eric Schulte
2012-05-30 16:58             ` Achim Gratz
2012-05-29 17:00         ` Mikhail Titov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='019b01cd3e7d$06cf3790$146da6b0$@us' \
    --to=mlt@gmx.us \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=eric.schulte@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.