From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#26242: 25.1; `dired-shrink-to-fit' warning Date: Fri, 24 Mar 2017 11:09:55 -0700 (PDT) Message-ID: <0159673c-b125-422a-b192-09e16132afa9@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1490379084 6548 195.159.176.226 (24 Mar 2017 18:11:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Mar 2017 18:11:24 +0000 (UTC) To: 26242@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 24 19:11:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crTg2-0000Mt-6m for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Mar 2017 19:11:06 +0100 Original-Received: from localhost ([::1]:34391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crTg8-0003nY-9l for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Mar 2017 14:11:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crTg2-0003mE-NJ for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:11:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crTfy-0003ay-IF for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:11:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1crTfy-0003au-Eb for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1crTfy-00085d-31 for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2017 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.149037901431035 (code B ref -1); Fri, 24 Mar 2017 18:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Mar 2017 18:10:14 +0000 Original-Received: from localhost ([127.0.0.1]:42727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crTfB-00084V-Mf for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crTf9-00084I-O7 for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crTf3-00036Z-3Z for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:06 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crTf3-00036T-0V for submit@debbugs.gnu.org; Fri, 24 Mar 2017 14:10:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crTf1-0003eR-VA for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crTex-00034x-SB for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:10:03 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:33901) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crTex-00034e-Js for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2017 14:09:59 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v2OI9vbj009766 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 24 Mar 2017 18:09:58 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v2OI9vUF023242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Mar 2017 18:09:57 GMT Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v2OI9ucn006349 for ; Fri, 24 Mar 2017 18:09:57 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130884 Archived-At: If code uses variable `dired-shrink-to-fit', this is the byte-compiler warning you get: Warning: =E2=80=98dired-shrink-to-fit=E2=80=99 is an obsolete variable (as = of 24.3); use the Customization interface to add a new rule to =E2=80=98display-buffer-alist=E2=80=99 where condition regexp is "^ \*Ma= rked Files\*$", action argument symbol is =E2=80=98window-height=E2=80=99 and its value is = nil. That is a _ridiculous_ warning. This simple variable was defined this way, for decades: (defvar dired-shrink-to-fit t ;; I see no reason ever to make this nil -- rms. ;; (> baud-rate search-slow-speed) "Non-nil means Dired shrinks the display buffer to fit the marked files."= ) IOW, the value should pretty much always be non-nil. What on Earth is the point of the convoluted recipe given in that warning? `dired-shrink-to-fit' was never a user option. It is not necessarily something that someone would set in their init file. It is just as likely (if it is likely at all - see RMS's comment) that it would be bound in some Lisp code. Why should we tell users to customize `display-buffer-alist', perhaps the most complex user option, and in such a way as to do the complicated things the warning suggests? What we should do is just restore the definition of `dired-shrink-to-fit' (perhaps even making it a constant with value `t'), or just replace occurrences of it with `t' and declare it obsolete but without such a silly warning that tells you to customize `display-buffer-alist'. In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-11-15 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --without-dbus --without-compress-install 'CFLAGS=3D-O2 -static -g3''