From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Date: Thu, 4 Dec 2008 09:23:57 -0800 Message-ID: <010101c95635$1812f200$c2b22382@us.oracle.com> References: <87fxl446mr.fsf@escher.local.home> Reply-To: Drew Adams , 1488@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1228411882 25796 80.91.229.12 (4 Dec 2008 17:31:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Dec 2008 17:31:22 +0000 (UTC) To: "'Stephen Berman'" , <1488@emacsbugs.donarmstrong.com>, Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 04 18:32:25 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L8I3p-0001jY-Iu for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2008 18:32:21 +0100 Original-Received: from localhost ([127.0.0.1]:51862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8I2e-0001E2-Q2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Dec 2008 12:31:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L8I1v-0000w1-1M for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 12:30:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L8I1q-0000tn-JF for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 12:30:19 -0500 Original-Received: from [199.232.76.173] (port=33153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8I1q-0000tX-DP for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 12:30:18 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53364) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L8I1p-0004mz-Uo for bug-gnu-emacs@gnu.org; Thu, 04 Dec 2008 12:30:18 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB4HUDOY004169; Thu, 4 Dec 2008 09:30:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB4HU43X003717; Thu, 4 Dec 2008 09:30:04 -0800 X-Loop: don@donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 04 Dec 2008 17:30:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1488 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1488-submit@emacsbugs.donarmstrong.com id=B1488.12284114482305 (code B ref 1488); Thu, 04 Dec 2008 17:30:04 +0000 Original-Received: (at 1488) by emacsbugs.donarmstrong.com; 4 Dec 2008 17:24:08 +0000 Original-Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB4HO55E002298 for <1488@emacsbugs.donarmstrong.com>; Thu, 4 Dec 2008 09:24:07 -0800 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mB4HNkMI017580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 4 Dec 2008 17:23:48 GMT Original-Received: from acsmt705.oracle.com (acsmt705.oracle.com [141.146.40.83]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mB4HO3Yb014656; Thu, 4 Dec 2008 17:24:04 GMT Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 04 Dec 2008 09:23:55 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87fxl446mr.fsf@escher.local.home> Thread-Index: AclWJIb4wR2aGf+bSVSxUg45OzKGzQAD+IVA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt705.oracle.com [141.146.40.83] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A09020B.4938122D.00A8:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 04 Dec 2008 12:30:19 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22944 gmane.emacs.pretest.bugs:23461 Archived-At: > From: Stephen Berman Sent: Thursday, December 04, 2008 1:44 AM > In GNU Emacs 23.0.60.21 (i686-pc-linux-gnu, GTK+ Version 2.12.9) > of 2008-12-03 on escher > 1. emacs -Q > 2. Eval this: > (define-minor-mode my-mm () "My minor mode." :global t > (if my-mm > (setq default-header-line-format > '(:eval (propertize "test" 'face '(:overline t)))) > (setq default-header-line-format nil))) > 3. Enable my-mm. > 4. C-x d foo (where `foo' is some directory with at least three files, > e.g. emacs/lisp). > 5. Mark three files in foo. > 6. Type `C' > ==> The popped up buffer *Marked Files* shows only two of the three > marked files. > > Likewise if the value of the 'face property in my-mm has a > non-nil :box attribute. In contrast, if the value of the 'face > property is '(:underline t) (but not '(:underline t :overline t)), > then in step 6 all three marked files are shown, though with no room > to spare. > > I guess the basic problem here is that Emacs calculates > window-height in integral equally sized line numbers. I think so; yes. This seems related to this bug: http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00765.html. A face that uses :box, :overline, etc. is a pixel or two taller. And that can cause code that deals with window size to increase by another line.