From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stephen Berman'" <Stephen.Berman@rub.de>,
<1488@emacsbugs.donarmstrong.com>, <emacs-pretest-bug@gnu.org>
Subject: bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer
Date: Thu, 4 Dec 2008 09:23:57 -0800 [thread overview]
Message-ID: <010101c95635$1812f200$c2b22382@us.oracle.com> (raw)
In-Reply-To: <87fxl446mr.fsf@escher.local.home>
> From: Stephen Berman Sent: Thursday, December 04, 2008 1:44 AM
> In GNU Emacs 23.0.60.21 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
> of 2008-12-03 on escher
> 1. emacs -Q
> 2. Eval this:
> (define-minor-mode my-mm () "My minor mode." :global t
> (if my-mm
> (setq default-header-line-format
> '(:eval (propertize "test" 'face '(:overline t))))
> (setq default-header-line-format nil)))
> 3. Enable my-mm.
> 4. C-x d foo (where `foo' is some directory with at least three files,
> e.g. emacs/lisp).
> 5. Mark three files in foo.
> 6. Type `C'
> ==> The popped up buffer *Marked Files* shows only two of the three
> marked files.
>
> Likewise if the value of the 'face property in my-mm has a
> non-nil :box attribute. In contrast, if the value of the 'face
> property is '(:underline t) (but not '(:underline t :overline t)),
> then in step 6 all three marked files are shown, though with no room
> to spare.
>
> I guess the basic problem here is that Emacs calculates
> window-height in integral equally sized line numbers.
I think so; yes.
This seems related to this bug:
http://lists.gnu.org/archive/html/emacs-devel/2007-03/msg00765.html.
A face that uses :box, :overline, etc. is a pixel or two taller. And that can
cause code that deals with window size to increase by another line.
next prev parent reply other threads:[~2008-12-04 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4940E3E8.8050501@gmx.at>
2008-12-04 9:44 ` bug#1488: 23.0.60; dired-pop-to-buffer: use fit-window-to-buffer Stephen Berman
2008-12-04 17:23 ` Drew Adams [this message]
2008-12-04 17:58 ` martin rudalics
2008-12-04 18:33 ` martin rudalics
2008-12-05 14:25 ` martin rudalics
2008-12-05 17:27 ` Stephen Berman
2008-12-05 17:37 ` martin rudalics
2008-12-05 18:17 ` Stephen Berman
2008-12-06 19:25 ` martin rudalics
2008-12-09 20:15 ` Stephen Berman
2008-12-11 17:29 ` martin rudalics
2008-12-11 10:05 ` bug#1488: marked as done (23.0.60; dired-pop-to-buffer: use fit-window-to-buffer) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010101c95635$1812f200$c2b22382@us.oracle.com' \
--to=drew.adams@oracle.com \
--cc=1488@emacsbugs.donarmstrong.com \
--cc=Stephen.Berman@rub.de \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.