From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Hopkins Newsgroups: gmane.emacs.bugs Subject: bug#65245: Possible code removal in eshell/diff (em-unix.el) Date: Sat, 12 Aug 2023 11:49:56 +0100 Message-ID: <00c46fb4ab8972714de3d338acbd5040@unbit.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31723"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Roundcube Webmail/1.5.2 To: 65245@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 12:51:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUmDA-00085p-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 12:51:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUmD2-0001nP-Ob; Sat, 12 Aug 2023 06:51:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUmD0-0001mz-9E for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:51:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUmD0-00078g-10 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUmCz-0005s5-UN for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Hopkins Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65245 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169183741922463 (code B ref -1); Sat, 12 Aug 2023 10:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Aug 2023 10:50:19 +0000 Original-Received: from localhost ([127.0.0.1]:48808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmCJ-0005qF-0D for submit@debbugs.gnu.org; Sat, 12 Aug 2023 06:50:19 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:35418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUmCF-0005pm-21 for submit@debbugs.gnu.org; Sat, 12 Aug 2023 06:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUmC9-0001Yl-FL for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:50:09 -0400 Original-Received: from weasel.tulip.relay.mailchannels.net ([23.83.218.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUmC6-0006mv-S4 for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 06:50:09 -0400 X-Sender-Id: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 16D10500FB6 for ; Sat, 12 Aug 2023 10:49:59 +0000 (UTC) Original-Received: from apollo.krystal.co.uk (unknown [127.0.0.6]) (Authenticated sender: 9wt3zsp42r) by relay.mailchannels.net (Postfix) with ESMTPA id 3C3DF500B87 for ; Sat, 12 Aug 2023 10:49:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1691837398; a=rsa-sha256; cv=none; b=gDLmNwjr8kegngplwz4ksf+uOJ7MDTYxhJTka5YNLBugmbuHIO5HSjBiRZ3R9J9T2tnc2w KXoP039a5T63MOLH36Kt0Kw4N+QWJc9wApGaTSIJ3Zg1Uu5MUBpsDAV+B02G4Nld03Zl9r uzY1Up6GInnRcLTFOyFekm/RYij+v7NFDcfUiOaGISkEyPJ60/CY0/uWbxpjpG6HUFJ96S +yBSbl+/4cgKFoz7xBoSuiP6euOY49a+ozbCQT36zHVBnkhXgAfTBEtnHai2MFNyspqdQh fy3W8veGdSq/k7DMh7NAGxBTvEthPiLoSbOn+4F84H/OA8ih4surwxCAKW4Htw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1691837398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:dkim-signature; bh=B7LGFU4gQcuEu9kMYFcK7WcF0LhTU8yuOKGOhzzOfVo=; b=8SPVTNhXGuLvxZEQRwFNbadL+171OSwqKfbvQmrbZk2FmsJ5oyM0hG//kUuagWQeStIJCy YzgQqmpb2nqjK8zumwNjNfbBatnNMGCRLzsvgs23V0eWwELkbmI/QKX1zmOCrYGkF4i9v7 tiStiY6s5Yf3WGeZtia3kcNJdGUN4cZ3hF+fYTLNomE4biMg24ABtDxLiymRvl9PQxcZOX Jz8YBxvhGjnfPGV+zD9zxVXFgxtmg752kxSr1y4yXDJphcBhPqVfw90WUDXgry1xkQ4Z9s x5uVcSX0ZRh5RbHUmQHiwR88lew505lAducbI2VxbG3qpNEV8mvAK+ZPTKEBLA== ARC-Authentication-Results: i=1; rspamd-849d547c58-h2f24; auth=pass smtp.auth=9wt3zsp42r smtp.mailfrom=emacs@unbit.co.uk X-Sender-Id: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk X-MC-Relay: Neutral X-MailChannels-SenderId: 9wt3zsp42r|x-authuser|emacs@unbit.co.uk X-MailChannels-Auth-Id: 9wt3zsp42r X-Lettuce-Skirt: 70d12cbb2ab603d7_1691837398748_1663746666 X-MC-Loop-Signature: 1691837398748:2716395436 X-MC-Ingress-Time: 1691837398748 Original-Received: from apollo.krystal.co.uk (apollo.krystal.co.uk [77.72.0.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.109.205.135 (trex/6.9.1); Sat, 12 Aug 2023 10:49:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=unbit.co.uk ; s=default; h=Content-Transfer-Encoding:Content-Type:Message-ID:Subject:To: From:Date:MIME-Version:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B7LGFU4gQcuEu9kMYFcK7WcF0LhTU8yuOKGOhzzOfVo=; b=lPMlTU+cbMsNpBRZVAtQVfCDy4 irqfGgsJxd2IWLocVqJXdU31qHiioA9iKpPd/t04Q9oP0ZPXMFAr8Md0ZUH73GaliB7g4nFB2iTv9 Csww4K99k/SN6gmo2GqBIPGEc/MjdPFbIgOSB/meba6BPtC4GkUeKFm0lBlHfWF6A7leXjEFyK8ZW jGJMGOJbfm1NPBT8UB0sRV3xJqGAHkJJ4p8durJP9FKo82xcZ/jqF9Q+I4n5yD2gbVA2V7YPh3Uis wbFWLE/x0Rwq4oNtpppj6lX2Y/RTur/rAAzY6LWe0LCEetH4LqPK9Vkt+Q6q9X3EPcBzBOwzl2G4T bl5Xz6LA==; Original-Received: from [::1] (port=57058 helo=apollo.krystal.co.uk) by apollo.krystal.co.uk with esmtpa (Exim 4.95) (envelope-from ) id 1qUmBz-00CFLw-1e for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 11:49:56 +0100 X-Sender: emacs@unbit.co.uk X-AuthUser: emacs@unbit.co.uk Received-SPF: pass client-ip=23.83.218.247; envelope-from=emacs@unbit.co.uk; helo=weasel.tulip.relay.mailchannels.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267300 Archived-At: Hi, I think the use of `compilation-finish-functions' and #'current-window-configuration can be removed from #'eshell/diff as it's no longer called and the intended functionality is achieved elsewhere. For example the below works with/without the `compilation-finish-functions'. $ emacs -Q -f eshell # in the eshell buffer echo a > a echo b > b diff -u a b # pops a #'diff-mode window with font-lock enabled; press q to quit Here are some commits showing the introduction and then others that help make it no longer relevant. 2001-04-24 ef59cfc6638a8ac3fccbee88482d142e95c32f81 Use `compilation-finish-functions' in #'eshell/diff 2004-02-02 c010ecfa9a26549486bb00c39221813c02c615de Bind q to #'quit-window in `diff-mode-shared-map' 2004-02-11 540d066630c55ab957dc08aa7abbca7775c9bd7b #'diff - don't use compile any more, use diff-mode instead. 2011-02-01 abef340a0c5304054a2a5e6d95e1d825501f0e7a `diff-mode-shared-map' inherit from `special-mode-map' Best, Richard