all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 'Juri Linkov' <juri@jurta.org>, emacs-devel@gnu.org
Subject: RE: breadcrumbs for Info . . . . . .
Date: Fri, 13 Jun 2008 15:11:10 -0700	[thread overview]
Message-ID: <00b101c8cda2$63175a50$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <jwvve0d9iqp.fsf-monnier+emacs@gnu.org>

> > Attached.
> 
> I installed a reworked version of this.

Thanks. However, what you installed is quite different (and there was no
discussion of the differences).

Anyway, here is some feedback:

. I generally like the replacement of File: and Node: by
  including that info in the breadcrumbs - bonne initiative.
  On the other hand (some food for thought):

  - The current node could be omitted from the crumbs, to save
    space, since it is already present in (a) the mode-line and
    (b) the node title.

  - If the file+top link is moved back to the header-line, more
    space is saved. In that case, it should be made into a (top)
    link. (I thought it already was a link, but I see now that
    that is in my own code). It is the breadcrumbs line where
    space is critical; it is likely to be longer than the
    header-line. The file is also listed in the mode-line.

  - Moving current and file+top to the header-line would probably
    eliminate any need for the depth option (except to turn off).

. When using ellipsis, I suggest dropping first the current
  node name and the file+top - precisely the parts you keep.
  This information is redundant (mode-line, title), and there
  is no action (link) associated with the current node. We have
  commands to go one level up (`u') and to the top (`t'). It is
  the intermediate levels that are most important to show - to
  (a) indicate hierarchical position and (b) provide links.

. The `>' appears even at the beginning: "> (dir)Top". That is
  unconventional and unclear to users, besides wasting a little
  space. Please remove the initial `>', to clearly indicate
  that the top node is the starting point of the chain. On the
  other hand, if you remove the top node to the header-line,
  then an initial `>' probably helps (for the same reason).

. The doc string of `Info-breadcrumbs-depth' should explain
  that it refers to the number of ancestor nodes, i.e., that it
  does not include the current node (so it is not the length of
  the breadcrumbs chain). It should also indicate which nodes
  are not displayed if too deep, and it should say that they
  are replaced by ellipsis.

. However, the depth value is in fact inconsistent. 1 means
  show one breadcrumbs of length 2 (including current), but
  0 means show breadcrumbs of length zero (i.e., don't show,
  but use File: and Node: instead). If the inconsistency is
  retained, then the doc string needs to explain it. It would
  be simplest to include the current node in the depth
  (assuming it will be part of the crumbs). In that case,
  either treat a value of 1 the same as 0, and mention that, or
  let 1 show just the current node.

. You might want to bind `Info-fontify-maximum-menu-size' to
  nil, as I did, for the calls to `Info-goto-node'. That will
  save useless extra fontification.

. So much for the time I spent shortening lines. You reverted
  to the original lengths, which includes lines up to 137 chars
  wide. No problem, but please don't bother to ask for that again.






  reply	other threads:[~2008-06-13 22:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10 23:52 breadcrumbs for Info . . . . . Drew Adams
2008-06-11  0:04 ` Juri Linkov
2008-06-11  3:18   ` Drew Adams
2008-06-11  9:34     ` Juri Linkov
2008-06-11 13:46       ` Drew Adams
2008-06-11 18:59         ` Eli Zaretskii
2008-06-11 22:40         ` Juri Linkov
2008-06-12  2:01           ` Miles Bader
2008-06-12 22:42           ` Drew Adams
2008-06-13  3:27             ` Stefan Monnier
2008-06-13  6:34               ` Drew Adams
2008-06-13  8:43                 ` Thien-Thi Nguyen
2008-06-13 13:55                   ` Drew Adams
2008-06-13 17:17                     ` Thien-Thi Nguyen
2008-06-13 17:52                       ` Drew Adams
2008-06-13 19:55                         ` Thien-Thi Nguyen
2008-06-13 20:10                           ` Drew Adams
2008-06-15 18:19                           ` Juri Linkov
2008-06-13 14:05                   ` Stefan Monnier
2008-06-13 15:12                     ` Drew Adams
2008-06-13 17:16                       ` Stefan Monnier
2008-06-13 18:32                     ` Thien-Thi Nguyen
2008-06-14  9:47                       ` Eli Zaretskii
2008-06-14 10:01                         ` Thien-Thi Nguyen
2008-06-13 13:58                 ` Stefan Monnier
2008-06-13 15:11                   ` Drew Adams
2008-06-13 20:34                     ` Stefan Monnier
2008-06-13 22:11                       ` Drew Adams [this message]
2008-06-13 22:44                         ` Stefan Monnier
2008-06-14  9:45                           ` Drew Adams
2008-06-14 16:16                             ` Stefan Monnier
2008-06-14 17:24                               ` Drew Adams
2008-06-14 18:04                                 ` Stefan Monnier
2008-06-15  0:27                                 ` Juri Linkov
2008-06-15  7:33                                   ` Drew Adams
2008-06-15 18:23                                     ` Juri Linkov
2008-06-15 19:46                                       ` Drew Adams
2008-06-15  0:28                       ` Juri Linkov
2008-06-15  2:04                         ` Stefan Monnier
2008-06-15 18:18                           ` Juri Linkov
2008-06-15  7:55                         ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00b101c8cda2$63175a50$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.