From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31194: 26.1; `display-buffer-in-major-side-window' was renamed without an alias. Date: Wed, 18 Apr 2018 20:42:23 +1200 Message-ID: <008907913f49882982e4f2555a3cb47f@webmail.orcon.net.nz> References: <30ad164462862e5a0cfff6b44481078a@webmail.orcon.net.nz> <1t36zt6dbs.fsf@fencepost.gnu.org> <1d1e92f3f706ee64471a3b5fe0c04ce6@webmail.orcon.net.nz> <5AD6F19C.3000208@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1524040868 23155 195.159.176.226 (18 Apr 2018 08:41:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Apr 2018 08:41:08 +0000 (UTC) User-Agent: Orcon Webmail Cc: 31194@debbugs.gnu.org, bug-gnu-emacs To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 18 10:41:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ieF-0005sZ-BJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 10:41:03 +0200 Original-Received: from localhost ([::1]:41285 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8igK-00089a-Io for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Apr 2018 04:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8igD-00089C-VA for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 04:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8igA-00041R-PJ for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 04:43:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50542) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8igA-00041C-LU for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 04:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8igA-0001mf-8x for bug-gnu-emacs@gnu.org; Wed, 18 Apr 2018 04:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Apr 2018 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31194-submit@debbugs.gnu.org id=B31194.15240409486814 (code B ref 31194); Wed, 18 Apr 2018 08:43:02 +0000 Original-Received: (at 31194) by debbugs.gnu.org; 18 Apr 2018 08:42:28 +0000 Original-Received: from localhost ([127.0.0.1]:58439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ifb-0001lq-MJ for submit@debbugs.gnu.org; Wed, 18 Apr 2018 04:42:27 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:50516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ifa-0001lh-OZ for 31194@debbugs.gnu.org; Wed, 18 Apr 2018 04:42:27 -0400 Original-Received: from [10.253.37.70] (port=45124 helo=webmail.orcon.net.nz) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1f8ifX-0005ih-H5; Wed, 18 Apr 2018 20:42:23 +1200 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Wed, 18 Apr 2018 20:42:23 +1200 In-Reply-To: <5AD6F19C.3000208@gmx.at> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145560 Archived-At: On 2018-04-18 19:19, martin rudalics wrote: > I've tried to do that now. Please have a look. Cheers. NEWS now says: > ** The function 'display-buffer-in-major-side-window' is now internal. > This hitherto undocumented function which existed since Emacs 24.1 has > been renamed to 'window--make-major-side-window' and its semantics > changed. Applications should use the now properly documented function > 'display-buffer-in-side-window' with appropriate arguments instead. "hitherto undocumented" isn't actually true? In Emacs 25.3, describe-function tells me: > display-buffer-in-major-side-window is a compiled Lisp function in > ‘window.el’. > > (display-buffer-in-major-side-window BUFFER SIDE SLOT &optional ALIST) > > Display BUFFER in a new window on SIDE of the selected frame. > SIDE must be one of ‘left’, ‘top’, ‘right’ or ‘bottom’. SLOT > specifies the slot to use. ALIST is an association list of > symbols and values as passed to ‘display-buffer-in-side-window’. > This function may be called only if no window on SIDE exists yet. > The new window automatically becomes the "major" side window on > SIDE. Return the new window, nil if its creation window failed. which is very similar to the docstring of the new function: > window--make-major-side-window is a compiled Lisp function in > ‘window.el’. > > (window--make-major-side-window BUFFER SIDE SLOT &optional ALIST) > > Display BUFFER in a new major side window on the selected frame. > SIDE must be one of ‘left’, ‘top’, ‘right’ or ‘bottom’. SLOT > specifies the slot to use. ALIST is an association list of > symbols and values as passed to ‘display-buffer-in-side-window’. > Return the new window, nil if its creation failed. > > This is an auxiliary function of ‘display-buffer-in-side-window’ > and may be called only if no window on SIDE exists yet. The main difference as far as the docstrings go seems to be: "This function may be called only if no window on SIDE exists yet", (and I don't know whether that's a difference in behaviour, or just improved documentation). This bit also seems wrong to me: > the now properly documented function 'display-buffer-in-side-window' As this function's docstring is unchanged between 25.3 and 26.1rc1. I would suggest something more like: ** The function 'display-buffer-in-major-side-window' no longer exists. It has been renamed as internal function 'window--make-major-side-window', however applications should instead call 'display-buffer-in-side-window' (passing the SIDE and SLOT parameters as elements of ALIST). This approach is backwards-compatible with versions of Emacs in which the old function is defined. n.b. I don't know if that last statement is correct back to 24.1? It's the impression I have, but someone else would need to confirm it.