From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#1291: 23.0.60; 1) resize-mini-windows: customizable, 2) if grow mini, grow Completions Date: Sun, 2 Nov 2008 11:05:35 -0800 Message-ID: <008101c93d1d$fc93a450$0200a8c0@us.oracle.com> References: <005b01c93c80$436e6ac0$0200a8c0@us.oracle.com> <490DB544.9000003@gmx.at> <007201c93cfd$5d33d440$0200a8c0@us.oracle.com> <490DEE1F.1090700@gmx.at> Reply-To: Drew Adams , 1291@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1225654232 1005 80.91.229.12 (2 Nov 2008 19:30:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Nov 2008 19:30:32 +0000 (UTC) Cc: 1291@emacsbugs.donarmstrong.com To: "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 02 20:31:34 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kwifa-0005JT-95 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Nov 2008 20:31:31 +0100 Original-Received: from localhost ([127.0.0.1]:34279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwieR-0006cP-ON for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Nov 2008 14:30:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KwieN-0006b3-O5 for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 14:30:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KwieL-0006YG-BK for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 14:30:15 -0500 Original-Received: from [199.232.76.173] (port=52334 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KwieL-0006YD-5d for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 14:30:13 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38690) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KwieK-0001RG-5F for bug-gnu-emacs@gnu.org; Sun, 02 Nov 2008 14:30:13 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA2JU4Pm005096; Sun, 2 Nov 2008 11:30:04 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mA2JF3h5001417; Sun, 2 Nov 2008 11:15:03 -0800 X-Loop: don@donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 02 Nov 2008 19:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1291 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1291-submit@emacsbugs.donarmstrong.com id=B1291.122565291932521 (code B ref 1291); Sun, 02 Nov 2008 19:15:03 +0000 Original-Received: (at 1291) by emacsbugs.donarmstrong.com; 2 Nov 2008 19:08:39 +0000 Original-Received: from rgminet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA2J8aOg032515 for <1291@emacsbugs.donarmstrong.com>; Sun, 2 Nov 2008 11:08:37 -0800 Original-Received: from rgminet15.oracle.com (mail-router.oracle.com [148.87.113.117]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mA2J8YeQ030611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 2 Nov 2008 19:08:37 GMT Original-Received: from rgmgw2.us.oracle.com (rgmgw2.us.oracle.com [138.1.186.111]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id mA2J8QVH005650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 2 Nov 2008 19:08:27 GMT Original-Received: from acsmt706.oracle.com (acsmt706.oracle.com [141.146.40.84]) by rgmgw2.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id mA2J5DoP015176; Sun, 2 Nov 2008 12:05:13 -0700 Original-Received: from dradamslap1 (/24.23.165.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 02 Nov 2008 19:05:12 +0000 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <490DEE1F.1090700@gmx.at> X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 Thread-Index: Ack9Fyt+KDDewZhWQViYTORYmtOc4gABhV5w X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Source-IP: rgmgw2.us.oracle.com [138.1.186.111] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090208.490DFAA9.00CA:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 02 Nov 2008 14:30:15 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22103 Archived-At: > From: martin rudalics Sent: Sunday, November 02, 2008 10:15 AM > > Previously (2008-10-09 build), the *Completions* buffer > > showed all of the candidates through `s==>Subdir', e.g. > > when I try it in a Dired buffer. It only left out one line, > > with the candidate `h==>Help'. Now, *Completions* leaves out > > all of these candidates: > > I'm afraid we won't get this very right ever. But you could try the > below version of `Electric-pop-up-window'. > > martin > > (defun Electric-pop-up-window (buffer &optional max-height) > (let* ((win (or (get-buffer-window buffer) (selected-window))) > (buf (get-buffer buffer)) > (one-window (one-window-p t)) > (pop-up-windows t) > (pop-up-frames nil)) > (if (not buf) > (error "Buffer %s does not exist" buffer) > (cond ((and (eq (window-buffer win) buf)) > (select-window win)) > (one-window > (pop-to-buffer buffer) > (setq win (selected-window))) > (t > (switch-to-buffer buf))) > ;; Don't shrink the window, but expand it if necessary. > (goto-char (point-min)) > (unless (<= (point-max) (window-end win t)) > (fit-window-to-buffer win max-height)) > win))) That seems to give the same behavior as the build of 2008-10-09: The last line is still not included in the *Completions* window. The problem is not that the *Completions* window is not fit properly by Electric-pop-up-window - it is. The problem is that after fitting it the minibuffer expansion reduces the *Completions* window. It should not. There ought to be a way to respect the *Completions* window size that we go to the trouble of creating by calling `fit-window-to-buffer'.