From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konrad Podczeck Newsgroups: gmane.emacs.bugs Subject: bug#62234: Toolbar does not work properly (with Emacs 29 or 30) Date: Sat, 18 Mar 2023 12:07:39 +0100 Message-ID: <005C11A2-7B88-4DED-B9FC-CE1EE1D69461@univie.ac.at> References: <83sfe3eqaf.fsf@gnu.org> <83jzzfegy0.fsf@gnu.org> <87a60a3nrj.fsf@yahoo.com> <871qlm3g9t.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Eli Zaretskii , 62234@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 12:21:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdUca-0005iq-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 12:21:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdUcT-0007cL-2g; Sat, 18 Mar 2023 07:21:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdUcR-0007bn-0Y for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdUcQ-0001I0-Og for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdUcQ-0003gE-Jy for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Konrad Podczeck Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62234 X-GNU-PR-Package: emacs Original-Received: via spool by 62234-submit@debbugs.gnu.org id=B62234.167913845314109 (code B ref 62234); Sat, 18 Mar 2023 11:21:02 +0000 Original-Received: (at 62234) by debbugs.gnu.org; 18 Mar 2023 11:20:53 +0000 Original-Received: from localhost ([127.0.0.1]:46399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUcH-0003fV-9D for submit@debbugs.gnu.org; Sat, 18 Mar 2023 07:20:53 -0400 Original-Received: from grace.univie.ac.at ([131.130.3.115]:43820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUcE-0003fK-LL for 62234@debbugs.gnu.org; Sat, 18 Mar 2023 07:20:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=univie.ac.at; s=rev3; h=To:References:Message-Id:Content-Transfer-Encoding: Cc:Date:In-Reply-To:From:Subject:Mime-Version:Content-Type:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=O+R87mSMh/YcbLM03UuKXWDa4CgKa6Hnez9zcVTpk7Y=; b=P025PxzaXwmLD7Bx3VMOgUPeAx T7+3k3QCC7gK0UdvDq6OozQa8I5fbFaCyime/IImQy2SK6cSTgksrYlb6gtF7GcQG0AwjzLphz3oI h0zKRMBs9bNriO/69IYxdIvK0Of6rJogVPZX+usrSV2MRSHYDHKNIza+zOKgSR6qKHr2DuM08E777 kPGPnpIigMDLTDGOhlVKXTb2CThE1Jk0/5Xx8FGdCQF/XdIA1B8CISM/wb0kuSrVmIfNxk3ZzU134 YlrJUiFhL5AOJG+NfPf0birZSj1Ehp14P+HmulM+lozOqKi5jhqXF1F998hYrdnRg1FpxQgZb53qX 1p2dfjMg==; Original-Received: from jarvis.univie.ac.at ([131.130.3.112] helo=jarvis.univie.ac.at) by grace.univie.ac.at with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pdUcC-00CZ5X-11; Sat, 18 Mar 2023 12:20:48 +0100 Original-Received: from 217-149-175-86.nat.highway.telekom.at ([217.149.175.86] helo=smtpclient.apple) by jarvis.univie.ac.at with esmtpsa (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.96) (envelope-from ) id 1pdUcC-009t6Z-0L; Sat, 18 Mar 2023 12:20:48 +0100 In-Reply-To: X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Univie-Virus-Scan: scanned by ClamAV on jarvis.univie.ac.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258161 Archived-At: After playing around a little bit, I confirm that Emacs now works as = expected. Thanks for your effort, konrad > Am 18.03.2023 um 11:25 schrieb Daniel Mart=C3=ADn = : >=20 > Po Lu writes: >=20 >>> +-(BOOL)validateToolbarItem:(NSToolbarItem *)toolbarItem >>> +{ >>> + return [toolbarItem isEnabled]; >>> +} >>> + >>=20 >> This does no harm on GNUstep. However, please indent with two = spaces, >> and place spaces after -, :, and ): >>=20 >> - (BOOL) validateToolbarItem: (NSToolBarItem *) toolbarItem >> { >> return [toolbarItem isEnabled]; >> } >>=20 >> Otherwise, LGTM. Thanks. >=20 > OK, I've attached a new version of the patch. Konrad, could you check > if with this patch the Emacs toolbar works as you expect? Thanks. >=20 > <0001-Fix-toolbar-item-validation-in-the-NS-port.patch>