From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2470: 23.0.90; auto-fill-mode, :minor-mode-function Date: Wed, 25 Feb 2009 09:59:33 -0800 Message-ID: <003701c99772$d0fbab30$c2b22382@us.oracle.com> Reply-To: Drew Adams , 2470@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1235586246 16661 80.91.229.12 (25 Feb 2009 18:24:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2009 18:24:06 +0000 (UTC) To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 19:25:22 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LcORV-0006li-V3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 19:25:14 +0100 Original-Received: from localhost ([127.0.0.1]:58734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcOQB-0001Wi-8K for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 13:23:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LcOQ4-0001Qx-HK for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 13:23:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LcOQ0-0001Ko-CI for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 13:23:42 -0500 Original-Received: from [199.232.76.173] (port=40602 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcOQ0-0001KG-4y for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 13:23:40 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52809) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LcOPz-0004ti-LP for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 13:23:39 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PINbTV031728; Wed, 25 Feb 2009 10:23:37 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1PI55AY025854; Wed, 25 Feb 2009 10:05:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 25 Feb 2009 18:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2470 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123558478623349 (code B ref -1); Wed, 25 Feb 2009 18:05:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 25 Feb 2009 17:59:46 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PHxgFH023337 for ; Wed, 25 Feb 2009 09:59:44 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:39569) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LcO0c-0008Hz-9j for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 12:57:26 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LcO2n-00010z-CD for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 12:59:41 -0500 Original-Received: from rcsinet13.oracle.com ([148.87.113.125]:27300 helo=rgminet13.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LcO2n-00010t-1Y for emacs-pretest-bug@gnu.org; Wed, 25 Feb 2009 12:59:41 -0500 Original-Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1PI0gcu010654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Feb 2009 18:00:44 GMT Original-Received: from acsmt701.oracle.com (acsmt701.oracle.com [141.146.40.71]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1PHxiU9018312 for ; Wed, 25 Feb 2009 17:59:46 GMT Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Feb 2009 17:59:30 +0000 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcmXctCJzHsFMr8USuWNNuSa9WxT6w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt701.oracle.com [141.146.40.71] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A0B0209.49A58708.00E9:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 25 Feb 2009 13:23:42 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25702 gmane.emacs.pretest.bugs:23988 Archived-At: 1. Someone on EmacsWiki asked how to tell if a given minor mode is on. I said to check the mode variable. The reply was that auto-fill-mode has no mode variable. The code shows this: (put 'auto-fill-function :minor-mode-function 'auto-fill-mode) ;; FIXME: turn into a proper minor mode. ;; Add a global minor mode version of it. (defun auto-fill-mode (&optional arg) ... So it seems to be in need of a fix, but I see no bug filed against it. 2. What is :minor-mode-function? It is used in a couple of places in the Emacs Lisp sources, with no comment or other explanation. It is not in the Elisp manual. It seems to be a way to associate a different function with a minor mode - a function with a different name from the mode itself. For example, `auto-fill-function' is the :minor-mode-function for `auto-fill-mode'. Is this mechanism still needed if `define-minor-mode' is used? Is it just for compatibility with XEmacs code and legacy code? How about documenting it - at least with a comment in the code somewhere: what is for, how and when to use it. In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600) of 2009-02-01 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)'