From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: bug#2470: 23.0.90; auto-fill-mode, :minor-mode-function
Date: Wed, 25 Feb 2009 09:59:33 -0800 [thread overview]
Message-ID: <003701c99772$d0fbab30$c2b22382@us.oracle.com> (raw)
1. Someone on EmacsWiki asked how to tell if a given minor mode is
on. I said to check the mode variable. The reply was that
auto-fill-mode has no mode variable.
The code shows this:
(put 'auto-fill-function :minor-mode-function 'auto-fill-mode)
;; FIXME: turn into a proper minor mode.
;; Add a global minor mode version of it.
(defun auto-fill-mode (&optional arg)
...
So it seems to be in need of a fix, but I see no bug filed against it.
2. What is :minor-mode-function? It is used in a couple of places in
the Emacs Lisp sources, with no comment or other explanation. It is
not in the Elisp manual. It seems to be a way to associate a
different function with a minor mode - a function with a different
name from the mode itself. For example, `auto-fill-function' is the
:minor-mode-function for `auto-fill-mode'.
Is this mechanism still needed if `define-minor-mode' is used? Is it
just for compatibility with XEmacs code and legacy code?
How about documenting it - at least with a comment in the code
somewhere: what is for, how and when to use it.
In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
next reply other threads:[~2009-02-25 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AcmXctCJzHsFMr8USuWNNuSa9WxT6w==>
2009-02-25 17:59 ` Drew Adams [this message]
2009-02-25 19:56 ` bug#2470: 23.0.90; auto-fill-mode, :minor-mode-function Stefan Monnier
2009-02-25 20:02 ` Drew Adams
2011-07-09 22:16 ` Juanma Barranquero
2011-07-09 23:10 ` Drew Adams
2011-07-09 23:18 ` Juanma Barranquero
2011-07-10 9:54 ` Drew Adams
2011-07-16 18:43 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003701c99772$d0fbab30$c2b22382@us.oracle.com' \
--to=drew.adams@oracle.com \
--cc=2470@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.