From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: RE: 23.0.60; kbd returns wrong value Date: Sat, 17 May 2008 17:00:25 -0700 Message-ID: <003501c8b87a$2d082ad0$0200a8c0@us.oracle.com> References: <003e01c8b534$31cbdd30$0200a8c0@us.oracle.com><004201c8b724$7c7cabb0$0200a8c0@us.oracle.com><86zlqqy4pq.fsf@lola.quinscape.zz><002301c8b830$8930d900$0200a8c0@us.oracle.com> <000a01c8b878$47627400$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1211068868 14085 80.91.229.12 (18 May 2008 00:01:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 May 2008 00:01:08 +0000 (UTC) To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 18 02:01:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JxWLD-0007kQ-EB for ged-emacs-devel@m.gmane.org; Sun, 18 May 2008 02:01:31 +0200 Original-Received: from localhost ([127.0.0.1]:48745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxWKT-0002Vi-Oa for ged-emacs-devel@m.gmane.org; Sat, 17 May 2008 20:00:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JxWKO-0002VT-Bz for emacs-devel@gnu.org; Sat, 17 May 2008 20:00:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JxWKM-0002V9-KM for emacs-devel@gnu.org; Sat, 17 May 2008 20:00:39 -0400 Original-Received: from [199.232.76.173] (port=32888 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxWKM-0002V6-Ap for emacs-devel@gnu.org; Sat, 17 May 2008 20:00:38 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33651) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JxWKL-0004dV-W7 for emacs-devel@gnu.org; Sat, 17 May 2008 20:00:38 -0400 Original-Received: from mail.gnu.org ([199.232.76.166]:54169 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JxWJD-00027W-V3 for emacs-pretest-bug@gnu.org; Sat, 17 May 2008 19:59:28 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JxWKH-0004bX-G3 for emacs-pretest-bug@gnu.org; Sat, 17 May 2008 20:00:37 -0400 Original-Received: from agminet01.oracle.com ([141.146.126.228]:34830) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JxWKH-0004bQ-4e for emacs-pretest-bug@gnu.org; Sat, 17 May 2008 20:00:33 -0400 Original-Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m4I00UTI018903 for ; Sat, 17 May 2008 19:00:30 -0500 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m4HNQ8HP020267 for ; Sat, 17 May 2008 18:00:30 -0600 Original-Received: from inet-141-146-46-1.oracle.com by acsmt351.oracle.com with ESMTP id 3674161941211068808; Sat, 17 May 2008 17:00:08 -0700 Original-Received: from dradamslap1 (/24.5.171.3) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 17 May 2008 17:00:08 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <000a01c8b878$47627400$0200a8c0@us.oracle.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 Thread-Index: Aci3N8U5jcZ9utV6Rhq0PIbY4FAzbQA+JLogABGM7CAAAML0kA== X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97336 gmane.emacs.pretest.bugs:22363 Archived-At: > > > >> After tracing edmacro-parse-keys, the problem seems to be here: > > > >> > > > >> (while (and (< pos (length string)) > > > >> (string-match "[^ \t\n\f]+" string pos)) > > > >> (let ((word (substring string (match-beginning 0) > > > >> (match-end 0))) > > > > > > (string-match "[^ \t\n\f<]+\\|<[^>]+>" ... instead? > > > > Yes, please install that fix; it seems to do the job. Thanks. > > Actually, no, that breaks it for "C-x <", producing only "^X" > (control-x character). > > The following regexp fixes that particular breakage: > "[^ \t\n\f<]+\\|<[^>]+>\\|<+" > > But that breaks other things. With input of "C-x <<>>", the > output is [24 < 62]. With input of "C-x << >>", the output is > [24 <\ 62]. In the vanilla code, e.g., the first produces > [24 <>], and the second produces "^X<<>>" (control-x char), > which are presumably correct. > > I have no idea what that is all about - there are no comments > in the code wrt what it is supposed to do with which inputs. > > It would be good if someone who really understands > `edmacro-parse-keys' would please take a look and fix it as > needed. And please add a doc string too. FYI - some more info about use of "[^ \t\n\f<]+\\|<[^>]+>\\|<+" as the regexp: Input of "M-<" produces "M-<", but it produces [134217788] with vanilla code (which is correct).