From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: RE: incorrect code in dired-insert-directory Date: Fri, 29 Feb 2008 07:00:43 -0800 Message-ID: <002f01c87ae3$dc416fe0$0600a8c0@us.oracle.com> References: <001f01c87aa1$f176d7c0$0600a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1204297412 11171 80.91.229.12 (29 Feb 2008 15:03:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Feb 2008 15:03:32 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 29 16:03:57 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JV6lo-0007yq-4B for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Feb 2008 16:03:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV6lH-0007Iz-R9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Feb 2008 10:02:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JV6k2-0006fv-RZ for bug-gnu-emacs@gnu.org; Fri, 29 Feb 2008 10:01:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JV6k1-0006fK-2q for bug-gnu-emacs@gnu.org; Fri, 29 Feb 2008 10:01:42 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JV6k0-0006fD-ND for bug-gnu-emacs@gnu.org; Fri, 29 Feb 2008 10:01:40 -0500 Original-Received: from rgminet01.oracle.com ([148.87.113.118]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JV6jv-0006o8-NQ; Fri, 29 Feb 2008 10:01:36 -0500 Original-Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id m1TF1VSC019764; Fri, 29 Feb 2008 08:01:31 -0700 Original-Received: from acsmt351.oracle.com (acsmt351.oracle.com [141.146.40.151]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m1T8m9OD010853; Fri, 29 Feb 2008 08:01:31 -0700 Original-Received: from inet-141-146-46-1.oracle.com by acsmt350.oracle.com with ESMTP id 3595192021204297257; Fri, 29 Feb 2008 07:00:57 -0800 Original-Received: from dradamslap1 (/141.144.80.6) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 29 Feb 2008 07:00:57 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ach6woX5yT3VygE0TNyQaqU50grg+gAIHCcg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17622 Archived-At: > > To reproduce (on Windows): > > > > emacs -Q > > Load the source file files.el. > > > > C-u C-x 4 d > > > > Use switches -lR, and enter some directory name. > > > > The first directory name in the buffer appears twice (the > others are OK). > > > > Note: The problem does not seem to arise if you don't load > > the source file, for some reason. > > If you load files.el in the MS-Windows port, make sure you load > ls-lisp.el right after that. That's because ls-lisp.el overloads the > standard version of insert-directory, defined by files.el, so loading > files.el reverts you to the original version of insert-directory, > which doesn't DTRT on Windows. > > Could it be that the whole problem does not exist if you load > ls-lisp.el after files.el? Good catch. That was it. No bug I guess. Nevertheless, would it make sense to: - Fix that regexp string anyway, to be Windows compatible? Or add a comment saying that it is not and need not be? - Add a comment in files.el or dired.el (or both) saying something about the fact that Windows redefines insert-directory in ls-lisp.el? FWIW, I spent quite a while trying to figure out what was actually happening and why (and I obviously didn't succeed completely). A comment in the source code might have helped me understand. Thx.