bug#977: 23.0.60; doc string of `filesets-data'

bug#977: 23.0.60; doc string of `filesets-data'

[Drew Adams]

This part of the doc string is incorrect:
 
  :pattern DIR PATTERN ... PATTERN is a regular expression
  comprising path and file pattern -- e.g. 'PATH/^REGEXP$'.
  Note the `^' at the beginning of the file name pattern.
 
I think this text reflects an older version of filesets.el, before the
change in :pattern format. See doc string of
`filesets-update-pre010505' for an explanation of the change in
format.
 
IIUC, DIR is a pattern that matches a directory and PATTERN is a
pattern that matches files (and subdirs) in that directory.  The old
format combinded DIR and PATTERN in one regexp, but they are now
separated, so the text about PATTERN "comprising path and file pattern
-- e.g. 'PATH/^REGEXP$'" is simply wrong.  (Besides which, we don't
use "path" this way in the Emacs doc - we use "directory" instead.)
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-09-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 

bug#977: marked as done (23.0.60; doc string of `filesets-data')

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]


Your message dated Thu, 23 Oct 2008 18:31:45 -0400
with message-id <87r667q6y6.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; doc string of `filesets-data'
has caused the Emacs bug report #977,
regarding 23.0.60; doc string of `filesets-data'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
977: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=977
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3583 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; doc string of `filesets-data'
Date: Sat, 13 Sep 2008 10:23:32 -0700
Message-ID: <002a01c915c5$72b3dae0$0200a8c0@us.oracle.com>

This part of the doc string is incorrect:
 
  :pattern DIR PATTERN ... PATTERN is a regular expression
  comprising path and file pattern -- e.g. 'PATH/^REGEXP$'.
  Note the `^' at the beginning of the file name pattern.
 
I think this text reflects an older version of filesets.el, before the
change in :pattern format. See doc string of
`filesets-update-pre010505' for an explanation of the change in
format.
 
IIUC, DIR is a pattern that matches a directory and PATTERN is a
pattern that matches files (and subdirs) in that directory.  The old
format combinded DIR and PATTERN in one regexp, but they are now
separated, so the text about PATTERN "comprising path and file pattern
-- e.g. 'PATH/^REGEXP$'" is simply wrong.  (Besides which, we don't
use "path" this way in the Emacs doc - we use "directory" instead.)
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-09-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 




[-- Attachment #3: Type: message/rfc822, Size: 1361 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Tom Link <sanobast-emacs@yahoo.de>
Cc: 977-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; doc string of `filesets-data'
Date: Thu, 23 Oct 2008 18:31:45 -0400
Message-ID: <87r667q6y6.fsf@cyd.mit.edu>

Tom Link <sanobast-emacs@yahoo.de> writes:

>> What's the difference between :tree and :pattern here?
>>   
> IIRC pattern isn't recursive.

Ok, thanks.  I've updated the docstring.

bug#977: 23.0.60; doc string of `filesets-data'

[Chong Yidong]

Hi Thomas, here's a documentation bug report for filesets.el:

> This part of the doc string is incorrect:
> 
>   :pattern DIR PATTERN ... PATTERN is a regular expression
>   comprising path and file pattern -- e.g. 'PATH/^REGEXP$'.
>   Note the `^' at the beginning of the file name pattern.
> 
> I think this text reflects an older version of filesets.el, before the
> change in :pattern format. See doc string of
> `filesets-update-pre010505' for an explanation of the change in
> format.
> 
> IIUC, DIR is a pattern that matches a directory and PATTERN is a
> pattern that matches files (and subdirs) in that directory.  The old
> format combinded DIR and PATTERN in one regexp, but they are now
> separated, so the text about PATTERN "comprising path and file pattern
> -- e.g. 'PATH/^REGEXP$'" is simply wrong.  (Besides which, we don't
> use "path" this way in the Emacs doc - we use "directory" instead.)

What's the difference between :tree and :pattern here?

bug#977: 23.0.60; doc string of `filesets-data'

[Tom Link]

> What's the difference between :tree and :pattern here?
>   
IIRC pattern isn't recursive.