all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stephen J. Turnbull'" <stephen@xemacs.org>
Cc: 'Stefan Monnier' <monnier@iro.umontreal.ca>,
	rms@gnu.org, emacs-devel@gnu.org
Subject: RE: byte-compile-nogroup-warn effectively disabled
Date: Mon, 9 Jun 2008 06:55:04 -0700	[thread overview]
Message-ID: <002a01c8ca38$6bfed020$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <871w37qbmj.fsf@uwakimon.sk.tsukuba.ac.jp>

>  > There is no reason at all to assume that the next option in the
>  > file should have the same group(s) as the previous one.
> 
> That's not what Stefan said, he said it gets the last group defined
> (which I assume means defgroup'ed) in the file.

Then I misunderstood that part; sorry. But it's irrelevant to the points I
raised. However the group is chosen from among those groups defined in the file,
there is no reason to assume that it is the appropriate one for defcustoms that
have no :group.

(I assume nothing happens if no group is defined in the file, even if there are
some :groups used in some defcustoms.)

Wrt to the rest of what you write, it seems you are arguing that it might be
convenient for some people who follow certain coding practices, since it would
mean they could skip the burden of adding :group to each definition, with the
side benefit of less verbose code.

That doesn't sound convincing, to me. This convenience for some in some use
cases will open the door to errors by all.

The one case where it might be relatively benign is if there is only one group
definition in the file, which you say is your common use case anyway.





  reply	other threads:[~2008-06-09 13:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 22:06 byte-compile-nogroup-warn effectively disabled Richard M Stallman
2008-06-09  1:55 ` Stefan Monnier
2008-06-09  6:46   ` Drew Adams
2008-06-09  8:02     ` Stephen J. Turnbull
2008-06-09 13:55       ` Drew Adams [this message]
2008-06-09 20:09         ` Stephen J. Turnbull
2008-06-09 20:26           ` Drew Adams
2008-06-09 17:22     ` Richard M Stallman
2008-06-10  1:17       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002a01c8ca38$6bfed020$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    --cc=stephen@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.