COMPLETING-READ Problem

COMPLETING-READ Problem

[Volkan YAZICI]

Hi,

While trying to implement a family of SQL identifier search functions,
I want to offer tab completion to previously searched SQL identifiers
-- besides builtin history functionality binded to M-p. For this
purpose, I try to use COMPLETING-READ. Here's the related code
snippet:

(defvar searched-sql-items nil
  "Association list of previously searched SQL items.")

(defun make-local-searched-sql-items ()
  "Creates per-buffer SEARCHED-SQL-ITEMS association list."
  (make-local-variable 'searched-sql-items))

(add-hook 'sql-mode-hook 'make-local-searched-sql-items)

(defun search-sql-table (table-name)
  "Search for specified TABLE-NAME in the current buffer."
  (interactive
   (let ((previously-searched-tables (assoc 'table searched-sql-
items)))
     (list
      (completing-read
       (if previously-searched-tables
           (format "Table name (default: %s): "
                   (first previously-searched-tables))
         "Table name: ")
       previously-searched-tables)))
   ;; Insert specified TABLE-NAME to SEARCHED-SQL-ITEMS.
   (let ((previously-searched-tables (assoc 'table searched-sql-
items)))
     (setf (assoc 'table searched-sql-items)
           ;; Move TABLE-NAME to top.
           (cons table-name (remove table-name previously-searched-
tables))))
   ;; Search table.
   (search-forward (format "CREATE TABLE %s" table-name))))

But for some reason, function doesn't work. (Does nothing during
execution.) I tried to place a (warn "TABLE-NAME: %s" table-name) just
after (interactive ...) block, but there doesn't appear anything in
the *Messages* buffer. Any ideas?


Regards.

Re: COMPLETING-READ Problem

[Thierry Volpiatto]

Volkan YAZICI <volkan.yazici@gmail.com> writes:

> Hi,
>
> While trying to implement a family of SQL identifier search functions,
> I want to offer tab completion to previously searched SQL identifiers
> -- besides builtin history functionality binded to M-p. For this
> purpose, I try to use COMPLETING-READ. Here's the related code
> snippet:
>
> (defvar searched-sql-items nil
>   "Association list of previously searched SQL items.")
>
> (defun make-local-searched-sql-items ()
>   "Creates per-buffer SEARCHED-SQL-ITEMS association list."
>   (make-local-variable 'searched-sql-items))
>
> (add-hook 'sql-mode-hook 'make-local-searched-sql-items)
>
> (defun search-sql-table (table-name)
>   "Search for specified TABLE-NAME in the current buffer."
>   (interactive
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (list
>       (completing-read
>        (if previously-searched-tables
>            (format "Table name (default: %s): "
>                    (first previously-searched-tables))
>          "Table name: ")
>        previously-searched-tables)))
>    ;; Insert specified TABLE-NAME to SEARCHED-SQL-ITEMS.
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (setf (assoc 'table searched-sql-items)
>            ;; Move TABLE-NAME to top.
>            (cons table-name (remove table-name previously-searched-
> tables))))
>    ;; Search table.
>    (search-forward (format "CREATE TABLE %s" table-name))))
>
> But for some reason, function doesn't work. (Does nothing during
> execution.) I tried to place a (warn "TABLE-NAME: %s" table-name) just
> after (interactive ...) block, but there doesn't appear anything in
> the *Messages* buffer. Any ideas?
>
>
> Regards.
>
I think you have to put your completing-read outside of the let body.
-- 
A + Thierry
Pub key: http://pgp.mit.edu

Re: COMPLETING-READ Problem

[Thierry Volpiatto]

Volkan YAZICI <volkan.yazici@gmail.com> writes:

> Hi,
>
> While trying to implement a family of SQL identifier search functions,
> I want to offer tab completion to previously searched SQL identifiers
> -- besides builtin history functionality binded to M-p. For this
> purpose, I try to use COMPLETING-READ. Here's the related code
> snippet:
>
> (defvar searched-sql-items nil
>   "Association list of previously searched SQL items.")
>
> (defun make-local-searched-sql-items ()
>   "Creates per-buffer SEARCHED-SQL-ITEMS association list."
>   (make-local-variable 'searched-sql-items))
>
> (add-hook 'sql-mode-hook 'make-local-searched-sql-items)
>
> (defun search-sql-table (table-name)
>   "Search for specified TABLE-NAME in the current buffer."
>   (interactive
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (list
>       (completing-read
>        (if previously-searched-tables
>            (format "Table name (default: %s): "
>                    (first previously-searched-tables))
>          "Table name: ")
>        previously-searched-tables)))
>    ;; Insert specified TABLE-NAME to SEARCHED-SQL-ITEMS.
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (setf (assoc 'table searched-sql-items)
>            ;; Move TABLE-NAME to top.
>            (cons table-name (remove table-name previously-searched-
> tables))))
>    ;; Search table.
>    (search-forward (format "CREATE TABLE %s" table-name))))
>
> But for some reason, function doesn't work. (Does nothing during
> execution.) I tried to place a (warn "TABLE-NAME: %s" table-name) just
> after (interactive ...) block, but there doesn't appear anything in
> the *Messages* buffer. Any ideas?
>
>
> Regards.
>
Or use let* to be able to reuse previously-searched-tables in completing-read.
-- 
A + Thierry
Pub key: http://pgp.mit.edu

RE: COMPLETING-READ Problem

[Drew Adams]

> While trying to implement a family of SQL identifier search functions,
> I want to offer tab completion to previously searched SQL identifiers
> -- besides builtin history functionality binded to M-p. For this
> purpose, I try to use COMPLETING-READ. Here's the related code
> snippet:
> 
> (defvar searched-sql-items nil
>   "Association list of previously searched SQL items.")
> 
> (defun make-local-searched-sql-items ()
>   "Creates per-buffer SEARCHED-SQL-ITEMS association list."
>   (make-local-variable 'searched-sql-items))
> 
> (add-hook 'sql-mode-hook 'make-local-searched-sql-items)
> 
> (defun search-sql-table (table-name)
>   "Search for specified TABLE-NAME in the current buffer."
>   (interactive
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (list
>       (completing-read
>        (if previously-searched-tables
>            (format "Table name (default: %s): "
>                    (first previously-searched-tables))
>          "Table name: ")
>        previously-searched-tables)))
>    ;; Insert specified TABLE-NAME to SEARCHED-SQL-ITEMS.
>    (let ((previously-searched-tables (assoc 'table searched-sql-
> items)))
>      (setf (assoc 'table searched-sql-items)
>            ;; Move TABLE-NAME to top.
>            (cons table-name (remove table-name previously-searched-
> tables))))
>    ;; Search table.
>    (search-forward (format "CREATE TABLE %s" table-name))))
> 
> But for some reason, function doesn't work. (Does nothing during
> execution.) I tried to place a (warn "TABLE-NAME: %s" table-name) just
> after (interactive ...) block, but there doesn't appear anything in
> the *Messages* buffer. Any ideas?

You pass `completing-read' an empty TABLE argument: you never fill
`previously-searched-tables', so it is nil.

And you never add any alist entry (table . <something) to
`searched-sql-items'. See
http://www.groupsrv.com/computers/about240758.html.

You need to think about or debug your code piece by piece.

Re: COMPLETING-READ Problem

[Volkan YAZICI]

On 9 Mart, 21:05, "Drew Adams" <drew.ad...@oracle.com> wrote:
> You pass `completing-read' an empty TABLE argument: you never fill
> `previously-searched-tables', so it is nil.
>
> And you never add any alist entry (table . <something) to
> `searched-sql-items'. Seehttp://www.groupsrv.com/computers/about240758.html.

(I totally missed the scope of LET block inside INTERACTIVE call.)
Thanks for your (setf (assoc ...) ...) pointer. It appears to be I
completely forgot how to use ASSOC. Anyway, after facing with some
other problems, I decided to continue with hash tables. Here is the
latest code:

(defun search-sql-table (table-name)
  "Search for specified TABLE-NAME in the current buffer."
  (interactive
   (let ((previously-searched-tables
          (and (hash-table-p searched-sql-items)
               (gethash 'table searched-sql-items))))
     (list
      (completing-read
       (if previously-searched-tables
           (format "Table name (default: %s): "
                   (first previously-searched-tables))
         "Table name: ")
       previously-searched-tables))))
  ;; Insert specified TABLE-NAME to SEARCHED-SQL-ITEMS.
  (unless (hash-table-p searched-sql-items)
    (setq searched-sql-items (make-hash-table)))
  (setf (gethash 'table searched-sql-items)
        ;; Move TABLE-NAME to top.
        (cons table-name (remove table-name (gethash 'table searched-
sql-items))))
  ;; Search table.
  (search-forward (format "CREATE TABLE %s" table-name)))

It seems to be working for now. If you see any other problems, I'd be
appreciated if you can report them. Thanks so much for your kindly
replies.


Regards.