From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Excessive use of `eassert` Date: Sun, 21 Jan 2024 12:35:01 -0800 Organization: UCLA Computer Science Department Message-ID: <0028eba2-7769-423e-927a-92faa86483d0@cs.ucla.edu> References: <83jzo5x0q8.fsf@gnu.org> <83sf2tv029.fsf@gnu.org> <811d5f03-fad4-47e1-b3fd-2f45229a5ee1@cs.ucla.edu> <838r4jrot7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28030"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: acm@muc.de, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 21 21:35:54 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rReXp-00074h-QG for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jan 2024 21:35:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rReX7-0003xv-JQ; Sun, 21 Jan 2024 15:35:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rReX6-0003xm-AD for emacs-devel@gnu.org; Sun, 21 Jan 2024 15:35:08 -0500 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rReX4-0000me-0q; Sun, 21 Jan 2024 15:35:08 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 2BD323C005164; Sun, 21 Jan 2024 12:35:02 -0800 (PST) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id 6iUAcFKkWPTN; Sun, 21 Jan 2024 12:35:01 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id D3B3F3C005165; Sun, 21 Jan 2024 12:35:01 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu D3B3F3C005165 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1705869301; bh=rJ4o27JzPJzFrQ8gfd6edIGiZDTR3eEy4cqwackaqv4=; h=Message-ID:Date:MIME-Version:To:From; b=S4judQBtd8pFbNcVkXsqhfazpvgbWDRWEABJwJ9YsVDrPJwqztDcCo8xEkVfLEpT8 Zzh33SKrw2NWIK9aMmXdDpvSCEGnOHKRh1K5ZkQM+3fIMeV1iD1cG2biNH+1ioVa64 r9aY2SrHQDaPZrf+eJN4PxV+lNFDhm5lDyZLr3+6kFgNkBNrsoWy95ZHlR5LmpBIU4 tt0fessFUaOxiq+5J1YmJXrgjqeVYMspkYuYvw2HX3vqdqvH6ufdDclv5zOGcRtix9 xK74oAE/FmPLniyHM/KBVQgVyiO/t75t5JFSJW01UJ7MAusu+KpagugXqpJY1Ga99S mpOuJz3vBRJ4g== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id nANnlSizhfE2; Sun, 21 Jan 2024 12:35:01 -0800 (PST) Original-Received: from [192.168.254.12] (unknown [47.148.192.211]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id AAFEA3C005164; Sun, 21 Jan 2024 12:35:01 -0800 (PST) Content-Language: en-US In-Reply-To: <838r4jrot7.fsf@gnu.org> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315192 Archived-At: On 2024-01-21 01:57, Eli Zaretskii wrote: > If you didn't benchmark, how did you see that these changes help > significantly the ENABLE_CHECKING build? I looked at the machine code generated (x86-64, current Fedora). In some cases it was quite a bit shorter, e.g., eliminating calls to make_lisp_ptr. Evidently I didn't catch the cases that Stefan noticed, so I'll try to see what's up there.