all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'martin rudalics'" <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: RE: display-buffer cleverness - how to tame?
Date: Tue, 5 May 2009 09:58:23 -0700	[thread overview]
Message-ID: <002301c9cda2$b4acf680$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <4A006A59.1000406@gmx.at>

>  > Is there some usual interpretation/use of that window arg?
> 
> The interpretation is "this is one of the windows Emacs 22 
> tried to split".

Is that the way it will be explained in the doc, by referring to Emacs 22's
(undocumented, magic) behavior?

I think it should be documented that `split-window-preferred-function', if
non-nil, is called by `display-buffer' potentially twice, to determine the
window (if any) to split. The first time, it is passed the largest window. Only
if it returns nil is it called a second time, with the lru window as argument.

Without this info, I don't think users will know what
`split-window-preferred-function' is about, hence how to code a suitable
function for it.

The doc string says that if `split-window-preferred-function' returns nil both
times, then `display-buffer' splits the window that respects the values of
`split-height-threshold' and `split-width-threshold'.

What if more than one window respects those values? Among which windows does
`display-buffer' choose, and how does it choose one of them, if more than one
respects those values? And what does it do if no window respects those values?
This info is missing, AFAICT.

It sounds as if no matter how `split-window-preferred-function' is defined,
`display-buffer' will split a window. Is that correct? That's what the doc
string seems to say - either `split-window-preferred-function' splits a window
or `display-buffer' splits one that respects `split-height-threshold' and
`split-width-threshold'.

If that's not true, then (besides fixing the doc), how can
`split-window-preferred-function' prevent window splitting altogether?

(Thanks for the other explanations. Hopefully, this info will make it into the
doc eventually.)





  reply	other threads:[~2009-05-05 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04  7:41 display-buffer cleverness - how to tame? Drew Adams
2009-05-04  8:38 ` martin rudalics
2009-05-04 14:39   ` Drew Adams
2009-05-04 15:03     ` Miles Bader
2009-05-04 15:49       ` Drew Adams
2009-05-04 18:58         ` Samuel Bronson
2009-05-05  2:50         ` Miles Bader
2009-05-04 16:36     ` Stefan Monnier
2009-05-04 16:41     ` martin rudalics
2009-05-04 17:13       ` Drew Adams
2009-05-05  7:02         ` martin rudalics
2009-05-05 14:18           ` Drew Adams
2009-05-05 16:33             ` martin rudalics
2009-05-05 16:58               ` Drew Adams [this message]
2009-05-05 18:55                 ` martin rudalics
2009-05-05 20:20                   ` Drew Adams
2009-05-06 16:21                     ` martin rudalics
2009-05-06 17:54                       ` Drew Adams
2009-05-07  9:37                         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301c9cda2$b4acf680$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.