all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: RE: shouldn't substitute-command-keys remove duplicates?
Date: Thu, 20 Mar 2008 21:59:49 -0700	[thread overview]
Message-ID: <002201c88b10$64aa5040$0600a8c0@us.oracle.com> (raw)
In-Reply-To: <002101c88b0e$a8e17510$0600a8c0@us.oracle.com>

As an example, filecache.el does this (via ;;;###autoload):

(define-key minibuffer-local-completion-map
            [C-tab] 'file-cache-minibuffer-complete)
(define-key minibuffer-local-map
            [C-tab] 'file-cache-minibuffer-complete)
(define-key minibuffer-local-must-match-map
            [C-tab] 'file-cache-minibuffer-complete)

This is in spite of the fact that minibuffer-local-map is
the parent of minibuffer-local-completion-map and
minibuffer-local-completion-map is the parent of
minibuffer-local-must-match-map.

The first and third bindings here are therefore superfluous,
but they serve to show that (substitute-command-keys
"\\{minibuffer-local-must-match-map\\}") doesn't remove the
duplicate entries:

minibuffer-local-must-match-map
-------------------------------

Local keymap for minibuffer input with completion, for exact
match.

key             binding
---             -------

C-g             abort-recursive-edit
TAB             minibuffer-complete
C-j             minibuffer-complete-and-exit
RET             minibuffer-complete-and-exit
ESC             Prefix Command
SPC             minibuffer-complete-word
?               minibuffer-completion-help
<C-tab>         file-cache-minibuffer-complete
<C-tab>         file-cache-minibuffer-complete
<C-tab>         file-cache-minibuffer-complete
<down>          next-history-element
...

> From: Drew Adams Sent: Thursday, March 20, 2008 9:47 PM
> Shouldn't substitute-command-keys remove duplicates?
>  
> If you explicitly bind a key to the same command in both a
> keymap km
> and its parent pkm, and then you call this, the binding is
> written
> twice:
>  
> (define-key km  "a" 'foo)
> (define-key pkm "a" 'foo)
>  
> (substitute-command-keys "\\{km\\}")
>  
> key             binding
> ---             -------
>  
> ...
> a  foo
> a  foo
> ...
>  
> In GNU Emacs 22.1.90.1 (i386-mingw-nt5.1.2600)
>  of 2008-01-30 on PRETEST
> Windowing system distributor `Microsoft Corp.', version
> 5.1.2600
> configured using `configure --with-gcc (3.4) --cflags
> -Ic:/gnuwin32/include'





  reply	other threads:[~2008-03-21  4:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21  4:47 shouldn't substitute-command-keys remove duplicates? Drew Adams
2008-03-21  4:59 ` Drew Adams [this message]
2008-03-21 17:21   ` Stefan Monnier
2008-03-22  1:29     ` Juri Linkov
2008-03-22  2:38       ` Drew Adams
2008-03-23  2:30         ` Juri Linkov
2008-03-23  5:59           ` Drew Adams
2008-03-22 17:07       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002201c88b10$64aa5040$0600a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.