From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Ben Key" Newsgroups: gmane.emacs.devel,gmane.emacs.sources Subject: RE: Patch for Windows implementation of play-sound Date: Thu, 17 Oct 2002 23:31:21 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: <001f01c27656$d45dd760$6401a8c0@GODDESS> References: <20021016181608.CD18.LEKTU@terra.es> Reply-To: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1035022146 15534 80.91.224.249 (19 Oct 2002 10:09:06 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 19 Oct 2002 10:09:06 +0000 (UTC) Cc: , Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 182qXY-00042O-00 for ; Sat, 19 Oct 2002 12:09:04 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 182rQP-0000Xb-00 for ; Sat, 19 Oct 2002 13:05:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 182qXv-0001zS-00; Sat, 19 Oct 2002 06:09:27 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 182qWq-0001JG-00 for emacs-devel@gnu.org; Sat, 19 Oct 2002 06:08:20 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 182qWo-0001I4-00 for emacs-devel@gnu.org; Sat, 19 Oct 2002 06:08:19 -0400 Original-Received: from gnudist.gnu.org ([199.232.41.7]) by monty-python.gnu.org with esmtp (Exim 4.10) id 182aLX-0008CW-01; Fri, 18 Oct 2002 12:51:35 -0400 Original-Received: from smtp-server3.tampabay.rr.com ([65.32.1.41]) by gnudist.gnu.org with esmtp (Exim 4.10) id 182NsO-0001cq-00; Thu, 17 Oct 2002 23:32:40 -0400 Original-Received: from GODDESS (6535194hfc48.tampabay.rr.com [65.35.194.48]) by smtp-server3.tampabay.rr.com (8.12.2/8.12.2) with SMTP id g9I3VG7Z019467; Thu, 17 Oct 2002 23:31:16 -0400 (EDT) Original-To: "'Juanma Barranquero'" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2911.0) In-reply-to: <20021016181608.CD18.LEKTU@terra.es> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 Importance: Normal Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8581 gmane.emacs.sources:195 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8581 I do have the newest MSSDK installed. Therefore, I am not getting the warnings you are getting. However, if I do not define _WIN32_WINNT and WINVER to be at least 0x0500 I get several compilation errors. As for the section of emacs.c you mentioned, you a correct that that was an unintentional change. Tomorrow I will create a new diff to resolve that problem. -----Original Message----- From: Juanma Barranquero [mailto:lektu@terra.es] Sent: Wednesday, October 16, 2002 12:34 PM To: Bkey1@tampabay.rr.com Cc: gnu-emacs-sources@gnu.org; emacs-devel@gnu.org Subject: Re: Patch for Windows implementation of play-sound On Wed, 16 Oct 2002 00:04:34 -0400, "Ben Key" wrote: > I have also tested this > patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08. Do you have a recent SDK from msdn.microsoft.com? The -DWINVER=0x0501 gives me about a gazillion of those: > NOTE: WINVER has been defined as 0x0500 or greater which enables > Windows NT 5.0 and Windows 98 features. When these headers were released, > Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the current versions. > > For this release when WINVER is defined as 0x0500 or greater, you can only > build beta or test applications. To build a retail application, > set WINVER to 0x0400 or visit http://www.microsoft.com/msdn/sdk > to see if retail Windows NT 5.0 or Windows 98 headers are available. > > See the SDK release notes for more information. Also, is this bit from src/emacs.c intended, or did you cvs diff and accidentally got this reversed? > @@ -2302,13 +2302,11 @@ > doc: /* Non-nil means Emacs is running without interactive terminal. */); > > DEFVAR_LISP ("kill-emacs-hook", &Vkill_emacs_hook, > - doc: /* Hook to be run when kill-emacs is called. > -Since `kill-emacs' may be invoked when the terminal is disconnected (or > + doc: /* Hook to be run whenever kill-emacs is called. > +Since kill-emacs may be invoked when the terminal is disconnected (or > in other similar situations), functions placed on this hook should not > expect to be able to interact with the user. To ask for confirmation, > -see `kill-emacs-query-functions' instead. > - > -The hook is not run in batch mode, i.e., if `noninteractive' is non-nil. */); > +see `kill-emacs-query-functions' instead. */); > Vkill_emacs_hook = Qnil; > > empty_string = build_string (""); /L/e/k/t/u