From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: RE: bookmark structure Date: Sat, 5 Apr 2008 09:53:02 -0700 Message-ID: <001a01c8973d$83946980$0200a8c0@us.oracle.com> References: <000d01c896b0$6044c7f0$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1207414475 12750 80.91.229.12 (5 Apr 2008 16:54:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2008 16:54:35 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 05 18:55:07 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JiBev-00051C-Jw for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2008 18:54:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiBeI-0000cV-UG for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Apr 2008 12:53:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JiBeE-0000b3-FB for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2008 12:53:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JiBeC-0000Yv-Q0 for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2008 12:53:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JiBeC-0000Yo-MG for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2008 12:53:44 -0400 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JiBeC-0003z3-Ok for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2008 12:53:45 -0400 Original-Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m35Greka009827; Sat, 5 Apr 2008 11:53:41 -0500 Original-Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id m35Cos2k032551; Sat, 5 Apr 2008 10:53:40 -0600 Original-Received: from inet-141-146-46-1.oracle.com by acsmt350.oracle.com with ESMTP id 3641262021207414382; Sat, 05 Apr 2008 09:53:02 -0700 Original-Received: from dradamslap1 (/141.144.64.62) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 05 Apr 2008 09:53:01 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 Thread-Index: AciXJ+RP5Amxc/w2QwynhglE0tuWTQAEt0lg X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17806 Archived-At: > > The doc string of bookmark-alist says each entry has this form: > > (NAME > > (filename . FILE) > > (front-context-string . FRONT-STR) > > (rear-context-string . REAR-STR) > > (position . POS) > > (info-node . POS) > > (annotation . ANNOTATION)) > > That's already fixed in the trunk. Still doesn't look right to me: "where each BOOKMARK is typically of the form \(NAME (\(filename . FILE\) \(front-context-string . FRONT-STR\) \(rear-context-string . REAR-STR\) \(position . POS\) \(annotation . ANNOTATION\)\)) So the cdr of each bookmark is an alist too." Aside from the unnecessary \'s (not a problem, but harder to read the code), the last sentence is misleading (and unnecessary). The cdr of each bookmark is a singleton list whose element is an alist. And what I said about the code comment still holds: > bookmark-name, string-in-front, string-behind, and the second > occurrence of annotation here should be uppercase here.