all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>, <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: RE: byte-compile-nogroup-warn effectively disabled
Date: Sun, 8 Jun 2008 23:46:00 -0700	[thread overview]
Message-ID: <001901c8c9fc$7b2960b0$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <jwvzlpvz84k.fsf-monnier+emacs@gnu.org>

> > effectively defeats the point of that warning, which is to
> > make sure that every defcustom and defface specifies the group.
> 
> I know it's your opinion, and I disagree.  Even without an
> explicit :group, the defcustom will have a proper group 
> attributed to it
> because it will use the last group defined in the file.  So, in my
> opinion it fixes the warning so that it only occurs in cases where the
> lack of the :group really leads to the variable being associated to no
> group at all.

Sorry, I haven't followed this. But IIUYC, I think it would be a mistake to
automatically assign an option or face the group that was last specified before
it in the same file.

What for? What is gained? Sounds like an invitation for user errors that won't
necessarily be noticed right away. It might not be an important error to assign
the wrong group, but why encourage that possibility?

What do you do when more than one :group is used in the previous defcustom? Do
you use the last one in that defcustom? Until now, :group order within a
defcustom has had no importance. Or do you use all of the :groups of that
defcustom?

In Icicles, for instance, I have several groups of options - for minibuffer
highlighting, completion behavior, *Completions* display, buffer treatment, key
bindings, key completion, matching, and so on. In some csaes, an option belongs
to more than one such group. I generally present the options in alphabetic order
in the file. There is no reason at all to assume that the next option in the
file should have the same group(s) as the previous one. If I forget to add a
:group, I would rather see a warning and have no group assigned than to have
some inappropriate group (not "a proper group") assigned. 

I don't see the point of this. Personally, I don't care much one way or the
other about the warnings - they are just an extra aid. But automatically
assigning groups sounds like asking for (minor) trouble.





  reply	other threads:[~2008-06-09  6:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 22:06 byte-compile-nogroup-warn effectively disabled Richard M Stallman
2008-06-09  1:55 ` Stefan Monnier
2008-06-09  6:46   ` Drew Adams [this message]
2008-06-09  8:02     ` Stephen J. Turnbull
2008-06-09 13:55       ` Drew Adams
2008-06-09 20:09         ` Stephen J. Turnbull
2008-06-09 20:26           ` Drew Adams
2008-06-09 17:22     ` Richard M Stallman
2008-06-10  1:17       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001901c8c9fc$7b2960b0$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.