From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#687: what was changed for mouse wheel? where is this documented? Date: Sat, 3 Jan 2009 10:16:34 -0800 Message-ID: <001701c96dcf$6a0db1b0$0200a8c0@us.oracle.com> Reply-To: Drew Adams , 687@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1231008227 30987 80.91.229.12 (3 Jan 2009 18:43:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Jan 2009 18:43:47 +0000 (UTC) Cc: 'Chong Yidong' To: <687@emacsbugs.donarmstrong.com> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 03 19:44:57 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LJBUS-00011a-5M for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2009 19:44:52 +0100 Original-Received: from localhost ([127.0.0.1]:52807 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJBT9-0005if-Qc for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2009 13:43:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJBT5-0005iQ-Hl for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 13:43:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJBT4-0005iE-1O for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 13:43:27 -0500 Original-Received: from [199.232.76.173] (port=51385 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJBT3-0005iB-Qv for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 13:43:25 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42019) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LJBT3-0001wa-Am for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2009 13:43:25 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n03IhNfM011219; Sat, 3 Jan 2009 10:43:23 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n03IP4MI006456; Sat, 3 Jan 2009 10:25:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Sat, 03 Jan 2009 18:25:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 687 X-Emacs-PR-Package: emacs,w32 X-Emacs-PR-Keywords: patch Original-Received: via spool by 687-submit@emacsbugs.donarmstrong.com id=B687.12310066075061 (code B ref 687); Sat, 03 Jan 2009 18:25:04 +0000 Original-Received: (at 687) by emacsbugs.donarmstrong.com; 3 Jan 2009 18:16:47 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from acsinet12.oracle.com (acsinet12.oracle.com [141.146.126.234]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n03IGevr005053 for <687@emacsbugs.donarmstrong.com>; Sat, 3 Jan 2009 10:16:41 -0800 Original-Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n03IG4X6016382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 3 Jan 2009 18:16:05 GMT Original-Received: from acsmt701.oracle.com (acsmt701.oracle.com [141.146.40.71]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n03IH5dc004526; Sat, 3 Jan 2009 18:17:07 GMT Original-Received: from dradamslap1 (/141.144.168.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 03 Jan 2009 18:16:29 +0000 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 Thread-Index: Acltz2kaC/CyQfeITBaYPJN8umjI3w== X-Source-IP: acsmt701.oracle.com [141.146.40.71] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.495FAB7F.0123:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sat, 03 Jan 2009 13:43:27 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23730 Archived-At: > >> I see. Can you verify that Lennart's patch works on W32? > > > > Lennart's patch works, but it might be better to make wheel events on > > W32 set the appropriate click, double or triple modifier so that it is > > caught by the conditions that follow. > > I have changed the code to make wheel events appear as click events > (double and triple wheel events were already handled correctly). > > I am still confused about all the steps an event goes through to become > a Lisp event, as the click modifier was being set on the wheel events, > but wasn't returned by event-modifiers, which seems to ignore the > modifiers and just use the base name of the event to regenerate them. > Are the modifiers we set in C code that untrustworthy? Sorry to interject, but which code did you change? I'd like to take a look. I don't see a recent change to mwheel.el in CVS. And I still see `wheel-(up|down)' events mentioned in the Elisp manual (in CVS). The Elisp manual still says that it is only on some systems that wheel movements get translated to `mouse-4' and `mouse-5'. And it explicitly advises, for portable code, to use variables `mouse-wheel-(up|down)-event'. Has this changed? I have code that tests for `wheel-up' and `wheel-down', for versions of Emacs starting with 21 (as well as other wheel tests for Emacs 20). I test those events in five different libraries. Likewise, I test, and bind, mouse-wheel-(up|down)-event. I also use a mouse that has 5 buttons, for which neither `mouse-4' nor `mouse-5' is the wheel in any way. It's useful to be able to distinguish a 4th and 5th mouse button from wheel movement. I'm interested to see how your change changes these things and whether it will break my code. Where would I find an explanation of what previously corresponds to what now, so I can adapt my code to work in Emacs 23 as well as previous versions? That is, how does the mouse wheel map to the various Emacs versions? So far, my code works with Emacs 20 through 22; I just need it to work with Emacs 23 also.