From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Newsgroups: gmane.emacs.bugs Subject: bug#38426: 27.0.50; [PATCH] * python.el: new function python-shell-send-statement Date: Sun, 15 Dec 2019 16:52:51 +0800 Message-ID: <001101d5b325$09fee800$1dfcb800$@zoom.us> References: <046101d5a690$b8e69bc0$2ab3d340$@zoom.us> <834ky36r03.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="251282"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, 38426@debbugs.gnu.org To: "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 15 09:54:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1igPfG-0013Bt-Ef for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 09:54:10 +0100 Original-Received: from localhost ([::1]:37162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igPfE-0004cK-Nc for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2019 03:54:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39422) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igPf9-0004cA-0V for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 03:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igPf7-0001lP-Qu for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 03:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igPf7-0001kT-Lk for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 03:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igPf7-0007gJ-Jk for bug-gnu-emacs@gnu.org; Sun, 15 Dec 2019 03:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2019 08:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38426-submit@debbugs.gnu.org id=B38426.157639998329432 (code B ref 38426); Sun, 15 Dec 2019 08:54:01 +0000 Original-Received: (at 38426) by debbugs.gnu.org; 15 Dec 2019 08:53:03 +0000 Original-Received: from localhost ([127.0.0.1]:35988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igPeB-0007ee-3s for submit@debbugs.gnu.org; Sun, 15 Dec 2019 03:53:03 -0500 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:34274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igPe9-0007eB-FQ for 38426@debbugs.gnu.org; Sun, 15 Dec 2019 03:53:01 -0500 Original-Received: by mail-pg1-f182.google.com with SMTP id r11so1917931pgf.1 for <38426@debbugs.gnu.org>; Sun, 15 Dec 2019 00:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language; bh=OwKFCMbyliEKAKzzevUibppcTBDlxHRZmktfK6BvxYg=; b=JiFRr0vZNKQGH02Kw9MnMoBJNRcB3tL+MpyuOmb+1sU/Av3U5UvpzKAIAEGWwAAh6E 8oSAgtgB5HdhfSXkqWE/tJqo5Cc1YYbAnFjwFUiMb3dQdKiR50oA67ybRe8sWYIO62db dl6J0b3eeECgK4WrUGk50SPMpZbn4QdrLhVec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language; bh=OwKFCMbyliEKAKzzevUibppcTBDlxHRZmktfK6BvxYg=; b=qopclq2W/z63jL72twcEZYH85tONN7bm6h4+pyVvTLLiBVeYgsHZnwHJ/F4V5ivjAc cbQhAQJ3HdUMCgEk7F7xo8c0bNWKcGCOGXZzg4DLAB2dUbCC2GEYyHav5GTcxqURKjTj RPIDL39io2syOEs+giDC4blL2ESaQRdL4LgzKBraQWnVUQddTQbTD6Z8YFAKXYspn/Dj q4sN0KkO63fLLbgIkgqT39V8YDKuvIDm30dU1UlVEXmf6Pg+IWiIiRr6IbqzAKK8a3Rf jP5rFyjHIBYzVxpn8SHn2MC6dMqSNCIVWdXiiCvYGdsGkfH5yklONlBG5Tx5ighyZm2/ VK0g== X-Gm-Message-State: APjAAAWB2WEtxpUXk0/fsKkR6ynLVpGhR0n9npzxEUccLvxNu4Rb7K2S PPklG7Z+9ZSnV+OIMkbB8o96WN5LqlD7VMbI83BcWlK9xu6YT4KLb8LgruHaWfwAReJ+uY2EFFG 4wlw9+LdD6bbyL8tL60nJVH0RPPcqRupwXsvmdvMkOVYrLp6AtJxBgFl0ctOW X-Google-Smtp-Source: APXvYqzlBWvReonOa864wD3WxXLzuNUS/Qwqwy4Ucv0OSBSI9lAzWXz4dE1euNLwT+DFcxPizQWNWA== X-Received: by 2002:aa7:9d9c:: with SMTP id f28mr9962241pfq.20.1576399975140; Sun, 15 Dec 2019 00:52:55 -0800 (PST) Original-Received: from DESKTOP71C1N5K ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id k15sm18016607pfg.37.2019.12.15.00.52.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Dec 2019 00:52:54 -0800 (PST) In-Reply-To: <834ky36r03.fsf@gnu.org> X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJSrwOcMWK/VGl6aQ25PebYFZ1Y3wISUE48prALxZA= Content-Language: en-us X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173367 Archived-At: Hi Eli, Thank you for your comments, they're very helpful, I had change the modifications according your comments. An individual mail with patch only is send, please check and review it again. Thanks. -----Original Message----- From: Eli Zaretskii Sent: Saturday, December 14, 2019 20:17 To: lin.sun@zoom.us Cc: 38426@debbugs.gnu.org; larsi@gnus.org Subject: Re: 27.0.50; [PATCH] * python.el: new function python-shell-send-statement > From: > Date: Fri, 29 Nov 2019 16:40:55 +0800 > > >From 61db0e91094297ddca302eaf691cf5b4ff82ebf6 Mon Sep 17 00:00:00 > >2001 > From: "lin.sun" > Date: Fri, 29 Nov 2019 03:10:12 -0500 > Subject: [PATCH] * python.el: new function python-shell-send-statement > > Add new function `python-shell-send-statement' and bind to key "C-c > C-e" for sending statement under cursor to inferior Python process. Thanks. A few comments below: > +(defun python-shell-send-statement (&optional send-main msg) > + "Send the statement delimited by > +`python-nav-beginning-of-statement' and The first line of a doc string should be a complete sentence, and it should mention the function's arguments. > +`python-nav-end-of-statement' to inferior Python process. When > +optional ^^ Our convention is to leave 2 spaces between sentences in documentation and comments, per US English rules. > + When > +optional argument MSG is non-nil, forces display of a user-friendly > +message if > there's > +no process running; default to t when called interactively. If there > +is > region > +be activated, it present as `python-shell-send-region'." These lines are too long, please wrap them to make them shorter, preferably no more than 75 characters. Please also provide a ChangeLog style commit log message, as described in CONTRIBUTE, and please mention the bug number there. And finally, this new command needs to be mentioned in NEWS, under "Python mode". Thanks.