From: Steven Tamm <steventamm@mac.com>
Cc: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Consolidation of image support in new image.c file.
Date: Wed, 10 Mar 2004 21:57:37 -0800 [thread overview]
Message-ID: <00109334-7321-11D8-80D6-00039390AB82@mac.com> (raw)
In-Reply-To: <m3znaob1p8.fsf@kfs-l.imdomain.dk>
I also could not bootstrap (or make for that matter): Some code was
left lying around macfns.c that defines Qjpeg and the like and
sys/stat.h wasn't included in image.c for OSX.
I checked in the following changes that make it compile (don't know if
it works yet... still bootstrapping):
*** src/macfns.c.~1.29.~ Wed Mar 10 16:27:13 2004
--- src/macfns.c Wed Mar 10 21:15:22 2004
***************
*** 4391,4412 ****
set_frame_fontset_func = x_set_font;
check_window_system_func = check_mac;
- Qjpeg = intern ("jpeg");
- staticpro (&Qjpeg);
-
- Qtiff = intern ("tiff");
- staticpro (&Qtiff);
-
- Qgif = intern ("gif");
- staticpro (&Qgif);
-
- Qpng = intern ("png");
- staticpro (&Qpng);
-
- defsubr (&Sclear_image_cache);
- defsubr (&Simage_size);
- defsubr (&Simage_mask_p);
-
hourglass_atimer = NULL;
hourglass_shown_p = 0;
*** src/image.c.~1.1.~ Wed Mar 10 16:28:24 2004
--- src/image.c Wed Mar 10 21:39:19 2004
***************
*** 92,97 ****
--- 92,98 ----
#include <alloca.h>
#endif
#ifdef MAC_OSX
+ #include <sys/stat.h>
#include <QuickTime/QuickTime.h>
#else /* not MAC_OSX */
#include <Windows.h>
-Steven
On Mar 10, 2004, at 5:40 PM, Kim F. Storm wrote:
>
> [This is sent to emacs-devel with CC to selected team members as the
> mailing list is still too slow to be useful].
>
> I have just committed changes which moves/merges/consolidates the
> image support code for the X, W32, and MAC platforms into a new file
> image.c.
>
> I have successfully tested this on X (with and without -nw).
>
> I have done as much code review as I can for the W32 and MAC ports,
> but I cannot do any actual compilation or testing on those platforms.
> So if you can test (and fix :-) it for me, I'd appreciate it.
>
> --
> Kim F. Storm <storm@cua.dk> http://www.cua.dk
>
next prev parent reply other threads:[~2004-03-11 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-11 1:40 Consolidation of image support in new image.c file Kim F. Storm
2004-03-11 1:14 ` Luc Teirlinck
2004-03-11 12:25 ` Kim F. Storm
2004-03-11 5:57 ` Steven Tamm [this message]
2004-03-11 12:25 ` Kim F. Storm
2004-03-11 22:16 ` YAMAMOTO Mitsuharu
2004-03-11 23:52 ` Kim F. Storm
-- strict thread matches above, loose matches on Subject: below --
2004-03-12 10:46 David PONCE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00109334-7321-11D8-80D6-00039390AB82@mac.com \
--to=steventamm@mac.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.