From: "Bob Floyd" <bobfloyd@comcast.net>
To: "'Juri Linkov'" <juri@linkov.net>
Cc: 45617@debbugs.gnu.org
Subject: bug#45617: <query-replace> loses the edit region. Works in 23.3, broke in 26.3
Date: Fri, 15 Jan 2021 10:09:46 -0800 [thread overview]
Message-ID: <000d01d6eb69$9c522190$d4f664b0$@net> (raw)
In-Reply-To: <87k0sgirr0.fsf@mail.linkov.net>
PS: The 1st patch has the same wrong behavior also!
-----Original Message-----
From: Juri Linkov [mailto:juri@linkov.net]
Sent: Wednesday, January 13, 2021 10:54 AM
To: Bob Floyd
Cc: 'Eli Zaretskii'; 45617@debbugs.gnu.org
Subject: Re: bug#45617: <query-replace> loses the edit region. Works in
23.3, broke in 26.3
> Perhaps another way to think about this is that emacs is "mode-less".
>
> I can begin a command, recurse into another, pop out and resume the first
> command.
>
> Without the patch, or minibuffer fix, <query-replace> breaks that design.
So here is a simpler patch that fixes all query-replace commands:
diff --git a/lisp/replace.el b/lisp/replace.el
index d41dc98a0d..16b80a8fd1 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -327,6 +336,7 @@ query-replace-read-to
(defun query-replace-read-args (prompt regexp-flag &optional noerror)
(unless noerror
(barf-if-buffer-read-only))
+ (save-mark-and-excursion
(let* ((from (query-replace-read-from prompt regexp-flag))
(to (if (consp from) (prog1 (cdr from) (setq from (car from)))
(query-replace-read-to from prompt regexp-flag))))
@@ -334,7 +344,7 @@ query-replace-read-args
(or (and current-prefix-arg (not (eq current-prefix-arg '-)))
(and (plist-member (text-properties-at 0 from)
'isearch-regexp-function)
(get-text-property 0 'isearch-regexp-function from)))
- (and current-prefix-arg (eq current-prefix-arg '-)))))
+ (and current-prefix-arg (eq current-prefix-arg '-))))))
(defun query-replace (from-string to-string &optional delimited start end
backward region-noncontiguous-p)
"Replace some occurrences of FROM-STRING with TO-STRING.
next prev parent reply other threads:[~2021-01-15 18:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 1:05 bug#45617: <query-replace> loses the edit region. Works in 23.3, broke in 26.3 Bob Floyd
2021-01-03 14:47 ` Eli Zaretskii
2021-01-03 19:18 ` Bob Floyd
2021-01-04 17:26 ` Eli Zaretskii
2021-01-04 17:37 ` Juri Linkov
2021-01-04 22:40 ` Bob Floyd
2021-01-05 18:27 ` Juri Linkov
2021-01-05 19:45 ` Bob Floyd
2021-01-06 17:44 ` Juri Linkov
2021-01-06 18:19 ` Eli Zaretskii
2021-01-06 22:10 ` Bob Floyd
2021-01-13 18:53 ` Juri Linkov
2021-01-15 1:22 ` Bob Floyd
2021-01-15 8:54 ` Juri Linkov
2021-01-15 11:23 ` Eli Zaretskii
2021-01-19 17:45 ` Juri Linkov
2021-01-19 18:39 ` Eli Zaretskii
2021-01-15 18:05 ` Bob Floyd
2021-01-19 17:43 ` Juri Linkov
2021-01-20 22:48 ` Bob Floyd
2021-01-20 23:23 ` Bob Floyd
2021-01-21 21:50 ` Juri Linkov
2021-01-22 17:31 ` Bob Floyd
2021-01-23 17:20 ` Juri Linkov
2021-01-23 18:03 ` Bob Floyd
2021-01-23 18:31 ` Juri Linkov
2021-01-24 20:40 ` Bob Floyd
2021-01-25 17:07 ` Juri Linkov
2021-01-25 18:13 ` Bob Floyd
2021-01-25 18:54 ` Juri Linkov
2021-01-25 19:34 ` Bob Floyd
2021-01-25 19:51 ` Juri Linkov
2021-01-26 0:34 ` Bob Floyd
2021-01-27 9:43 ` Juri Linkov
2021-01-28 16:31 ` Bob Floyd
2021-01-28 18:42 ` Juri Linkov
2021-01-28 21:32 ` Bob Floyd
2021-01-29 8:56 ` Juri Linkov
2021-01-15 18:09 ` Bob Floyd [this message]
2021-01-07 18:46 ` Juri Linkov
2021-01-07 19:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000d01d6eb69$9c522190$d4f664b0$@net' \
--to=bobfloyd@comcast.net \
--cc=45617@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.