From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Lukasz Stafiniak" Newsgroups: gmane.emacs.devel Subject: Re: any comments before i apply patch? (was: Re: Calc: Big Lang matrix display, `apart' bug fix) Date: Sat, 23 Aug 2003 18:27:53 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <000d01c36993$b243c280$b1ee4dd5@ppp> References: <000201c125d6$115e3420$9aee4dd5@ppp> <873cftpl9r.fsf@gnufans.net> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1061656441 16026 80.91.224.253 (23 Aug 2003 16:34:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 23 Aug 2003 16:34:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Aug 23 18:34:00 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19qbKy-0001Gt-00 for ; Sat, 23 Aug 2003 18:34:00 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19qbPf-0006ES-00 for ; Sat, 23 Aug 2003 18:38:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19qbGC-0003jC-SP for emacs-devel@quimby.gnus.org; Sat, 23 Aug 2003 12:29:04 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19qbFi-0003hF-Nl for emacs-devel@gnu.org; Sat, 23 Aug 2003 12:28:34 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19qbFC-0003Bz-Dk for emacs-devel@gnu.org; Sat, 23 Aug 2003 12:28:33 -0400 Original-Received: from [212.77.101.161] (helo=smtp.wp.pl) by monty-python.gnu.org with esmtp (Exim 4.20) id 19qbFC-0003A5-0Q for emacs-devel@gnu.org; Sat, 23 Aug 2003 12:28:02 -0400 Original-Received: (WP-SMTPD 10295 invoked from network); 23 Aug 2003 16:27:59 -0000 Original-Received: from pb177.legnica.cvx.ppp.tpnet.pl (HELO ppp) (luk_stafi@[213.77.238.177]) (envelope-sender ) by smtp.wp.pl (wp-smtpd) with SMTP for ; 23 Aug 2003 16:27:59 -0000 Original-To: "D. Goel" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-AntiVirus: skaner antywirusowy poczty Wirtualnej Polski S. A. X-WP-ChangeAV: 0 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:16107 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16107 > > Lukasz (the new calc maintainer) has asked me to apply this calc patch > since his CVS is not working correctly. > > I am now knowledgable about what Lukasz has done here. Do any calc > gurus/enthusiasts have any comments/objections before I apply this > patch? > > Lukasz, can you please describe in english what your patch does? > > > DG http://gnufans.net/~deego/ > -- It is really a little thing. First, matrix display in Big Language mode: Before, entries to the matrix were actually printed in Flat Language Now, they are printed in Big Language, with vertical boxes expanded to the size of the highest expression in a row Second, `apart' bug fix: Before, inside `math-partial-fractions', `math-padded-polynomial' calculated the polynomial representation of the remainder using `math-is-polynomial' and not taking into consideration, that the last one might return nil After, I inlined `math-padded-polynomial' to compute `math-is-polynomial' and in case the latter returns nil, report an error "Expected a rational function". Best wishes, Lukasz