binding `display-time' modeline clickies to mouse-1

binding `display-time' modeline clickies to mouse-1

[John Paul Wallington]

Given that most modeline clickies are bound to mouse-1 and we now
live in a `mouse-1-click-follows-link' Emacs world, any objections to
this change?

2008-06-08  John Paul Wallington  <jpw@pobox.com>

	* time.el (display-time-string-forms): Use `mouse-1' to read mail.
	(display-time-update): Use `mouse-1' to cycle load average display.

--- time.el.~1.110.~	2008-05-10 16:50:54.000000000 +0100
+++ time.el	2008-06-08 05:04:32.000000000 +0100
@@ -289,9 +289,9 @@
 			      (if (stringp bg)
 				  (list :background bg)))))
 	  'face display-time-mail-face
-	  'help-echo "You have new mail; mouse-2: Read mail"
+	  'help-echo "You have new mail; mouse-1: Read mail"
 	  'mouse-face 'mode-line-highlight
-	  'local-map (make-mode-line-mouse-map 'mouse-2
+	  'local-map (make-mode-line-mouse-map 'mouse-1
 					       read-mail-command)))
       ""))
   "*List of expressions governing display of the time in the mode line.
@@ -383,7 +383,7 @@
 			 (propertize
 			  (concat (substring str 0 -2) "." (substring str -2))
 			  'local-map (make-mode-line-mouse-map
-				      'mouse-2 'display-time-next-load-average)
+				      'mouse-1 'display-time-next-load-average)
 			  'mouse-face 'mode-line-highlight
 			  'help-echo (concat
 				      "System load average for past "
@@ -392,7 +392,7 @@
 					(if (= 1 display-time-load-average)
 					    "5 minutes"
 					  "15 minutes"))
-				      "; mouse-2: next"))))
+				      "; mouse-1: next"))))
 		   (error ""))))
          (mail-spool-file (or display-time-mail-file
                               (getenv "MAIL")

RE: binding `display-time' modeline clickies to mouse-1

[Drew Adams]

> Given that most modeline clickies are bound to mouse-1 and we now
> live in a `mouse-1-click-follows-link' Emacs world, any objections to
> this change?
> -	  'help-echo "You have new mail; mouse-2: Read mail"
> +	  'help-echo "You have new mail; mouse-1: Read mail"
...

Living in a world with `mouse-1-click-follows-link' does not mean living in a
world where that variable is necessarily non-nil.

It is a mistake to hard-code things like this.

If hard-coding cannot be avoided for some reason, then the echo should be
ambiguous about which mouse button is used: just "click".