bug#2257: 23.0.90; grep-files-history has inappropriate default value

bug#2257: 23.0.90; grep-files-history has inappropriate default value

[Drew Adams]

emacs -Q
M-x load-library grep
C-h v grep-files-history
shows:
 
 grep-files-history is a variable defined in `grep.el'.
 Its value is ("ch" "el")
 Documentation:
 Not documented as a variable.
 
Besides the fact that there should be a doc string, the default value
should be nil.  `grep' already DTRT to fill the history with
appropriate default values for `M-n'. The default value of
`grep-files-history' is used only when no appropriate default values
are found.
 
And in that case, no default values should be available - it makes no
sense to propose inappropriate values. There is no reason for the
(first) default value to be proposed as [ch] in all cases - or in any
cases where a .c or .h file is not expected. Better for Emacs to
simply say that no default value is available.
 
 
 
In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
 of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 

bug#2257: marked as done (23.0.90; grep-files-history has inappropriate default value)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

Your message dated Mon, 07 Dec 2009 19:38:54 +0200
with message-id <87my1u1y6p.fsf@mail.jurta.org>
and subject line Re: 23.0.90; grep-files-history has inappropriate default value
has caused the Emacs bug report #2257,
regarding 23.0.90; grep-files-history has inappropriate default value
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2257: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2257
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3684 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.90; grep-files-history has inappropriate default value
Date: Mon, 9 Feb 2009 15:46:56 -0800
Message-ID: <000001c98b10$b1c9f4b0$0200a8c0@us.oracle.com>

emacs -Q
M-x load-library grep
C-h v grep-files-history
shows:
 
 grep-files-history is a variable defined in `grep.el'.
 Its value is ("ch" "el")
 Documentation:
 Not documented as a variable.
 
Besides the fact that there should be a doc string, the default value
should be nil.  `grep' already DTRT to fill the history with
appropriate default values for `M-n'. The default value of
`grep-files-history' is used only when no appropriate default values
are found.
 
And in that case, no default values should be available - it makes no
sense to propose inappropriate values. There is no reason for the
(first) default value to be proposed as [ch] in all cases - or in any
cases where a .c or .h file is not expected. Better for Emacs to
simply say that no default value is available.
 
 
 
In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
 of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 




[-- Attachment #3: Type: message/rfc822, Size: 1859 bytes --]

From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 2257-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.90; grep-files-history has inappropriate default value
Date: Mon, 07 Dec 2009 19:38:54 +0200
Message-ID: <87my1u1y6p.fsf@mail.jurta.org>

> emacs -Q
> M-x load-library grep
> C-h v grep-files-history
> shows:
>
>  grep-files-history is a variable defined in `grep.el'.
>  Its value is ("ch" "el")
>  Documentation:
>  Not documented as a variable.
>
> Besides the fact that there should be a doc string, the default value
> should be nil.

Thanks for the bug report.  This is fixed by bug#4301.

-- 
Juri Linkov
http://www.jurta.org/emacs/