From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lawrence Mitchell Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; ielm doesn't handle comments Date: Fri, 15 Feb 2008 08:49:56 +0000 Organization: funfunfun Message-ID: References: <9c1b17790802131614p1f113873tbba17ec5af03c8ed@mail.gmail.com> <87k5l7mlpy.fsf@bzg.ath.cx> <87ve4rl337.fsf@bzg.ath.cx> <87ir0rdpat.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203065423 20493 80.91.229.12 (15 Feb 2008 08:50:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Feb 2008 08:50:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 15 09:50:47 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JPwHO-0005Mu-FT for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2008 09:50:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPwGu-0007wi-K2 for ged-emacs-devel@m.gmane.org; Fri, 15 Feb 2008 03:50:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JPwGq-0007wX-JP for emacs-devel@gnu.org; Fri, 15 Feb 2008 03:50:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JPwGo-0007wD-Jf for emacs-devel@gnu.org; Fri, 15 Feb 2008 03:50:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JPwGo-0007w8-DC for emacs-devel@gnu.org; Fri, 15 Feb 2008 03:50:10 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JPwGn-0000q9-Um for emacs-devel@gnu.org; Fri, 15 Feb 2008 03:50:10 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JPwGh-0001bj-9L for emacs-devel@gnu.org; Fri, 15 Feb 2008 08:50:03 +0000 Original-Received: from 87-194-159-212.bethere.co.uk ([87.194.159.212]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 15 Feb 2008 08:50:03 +0000 Original-Received: from wence by 87-194-159-212.bethere.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 15 Feb 2008 08:50:03 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 28 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 87-194-159-212.bethere.co.uk Mail-Copies-To: nobody User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (darwin) Cancel-Lock: sha1:uYW4DxqOSdN4vjTyzw5tQ0DVfOY= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89145 Archived-At: Bastien wrote: [...] > Right. I have come up with another solution, not relying on font-lock, > but this one doesn't allow the double-quote character in comments. > Please improve it if you can. If no objection/suggestion until next > week, I'll apply this one. I think the right way to fix this is to allow ielm to read the form as it currently does (using read-from-string) and then discard following input if it contains either merely whitespace (as is currently the case) or a comment. The patch I proposed in (http://permalink.gmane.org/gmane.emacs.devel/89087) does this correctly, I think. Cheers, Lawrence [...] -- Lawrence Mitchell