all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lawrence Mitchell <wence@gmx.li>
To: emacs-devel@gnu.org
Subject: Re: 23.0.50; ielm doesn't handle comments
Date: Fri, 15 Feb 2008 19:44:30 +0000	[thread overview]
Message-ID: <?fnord?m2myq29f8h.fsf@ID-97657.user.individual.net> (raw)
In-Reply-To: 871w7ekwjn.fsf@bzg.ath.cx

Bastien Guerry wrote:
> Bastien Guerry <bzg@altern.org> writes:

>>> I think the right way to fix this is to allow ielm to read the
>>> form as it currently does (using read-from-string) and then
>>> discard following input if it contains either merely whitespace
>>> (as is currently the case) or a comment.

>> I will apply this with the ChangeLog you provided if you agree.

> Applied.

I realise the patch I sent didn't fix the docstring of
ielm-is-whitespace-or-comment correctly.  How about this:

diff --git a/lisp/ielm.el b/lisp/ielm.el
index a925558..5e1921e 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -301,7 +301,7 @@ simply inserts a newline."
 ;;; Utility functions
 
 (defun ielm-is-whitespace-or-comment (string)
-  "Return non-nil if STRING is all whitespace."
+  "Return non-nil if STRING is all whitespace or a comment."
   (or (string= string "") 
       (string-match "\\`[ \t\n]*\\(?:;.*\\)*\\'" string)))
 

ChangeLog:

Lawrence Mitchell <wence@gmx.li>

         * ielm.el (ielm-is-whitespace-or-comment): Docstring
           fix.

Cheers,

Lawrence
-- 
Lawrence Mitchell <wence@gmx.li>





  reply	other threads:[~2008-02-15 19:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14  0:14 23.0.50; ielm doesn't handle comments Adam Winiecki
2008-02-14 16:10 ` Lawrence Mitchell
2008-02-15  0:03   ` Richard Stallman
2008-02-14 18:11 ` Richard Stallman
2008-02-14 18:33   ` Bastien Guerry
2008-02-14 19:11     ` Reiner Steib
2008-02-14 20:01       ` Bastien Guerry
2008-02-14 21:07         ` Lawrence Mitchell
2008-02-15  0:41           ` Bastien
2008-02-15  8:49             ` Lawrence Mitchell
2008-02-15 14:27               ` Bastien Guerry
2008-02-15 16:35                 ` Bastien Guerry
2008-02-15 19:44                   ` Lawrence Mitchell [this message]
2008-02-16 16:21                     ` Bastien
2008-02-16 17:40                       ` Lawrence Mitchell
2008-02-16 18:17                         ` Bastien Guerry
2008-02-16 23:11                         ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='?fnord?m2myq29f8h.fsf@ID-97657.user.individual.net' \
    --to=wence@gmx.li \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.