From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthias Newsgroups: gmane.emacs.help Subject: Re: Defadvice use Date: 18 Apr 2005 23:07:33 +0200 Organization: Dans quel but ? Message-ID: References: <87acnw0yek.fsf-monnier+gnu.emacs.help@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1113858611 31269 80.91.229.2 (18 Apr 2005 21:10:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 18 Apr 2005 21:10:11 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Apr 18 23:10:07 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DNdTx-00084k-IX for geh-help-gnu-emacs@m.gmane.org; Mon, 18 Apr 2005 23:08:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DNdY8-0001Gc-Jd for geh-help-gnu-emacs@m.gmane.org; Mon, 18 Apr 2005 17:12:56 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!postnews.google.com!news1.google.com!proxad.net!freenix!uvsq.fr!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 26 Original-NNTP-Posting-Host: fermat.math.uvsq.fr Original-X-Trace: io.uvsq.fr 1113858453 56625 193.51.32.1 (18 Apr 2005 21:07:33 GMT) Original-X-Complaints-To: Newsmaster@uvsq.fr Original-NNTP-Posting-Date: Mon, 18 Apr 2005 21:07:33 +0000 (UTC) User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 Original-Xref: shelby.stanford.edu gnu.emacs.help:130228 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:25795 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:25795 Stefan Monnier wrote: Thanks for your indication. > (...) In general, I don't think there's a better way. I would argue > that if you need to use such an ugly hack, you should only be > morally allowed to do that after sending a patch that will make it > unnecessary in the future. You're true. I am working on `dired-do-shell-command' and alike commands (defined in Dired and Dired-X): I'd like them to be completion compliant via the useful library Shell Command from Masatoshi Tsuchiya. The doc spec of `dired-read-shell-command' says `This is an extra function so that you can redefine it, e.g., to use gmhist.' Dired-X do this: it redefines the command using `defun'. I feel like it's very ugly... But my knowledge in elisp is somewhat limited: I am not an esthète! So, I question now: Do you recommend that my patch change this (one could use a variable containing the name of a function...)? -- Matthias