From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.help Subject: Re: elisp macros problem Date: 27 Jul 2004 09:14:52 +0200 Organization: Organization?!? Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090912632 30410 80.91.224.253 (27 Jul 2004 07:17:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 27 Jul 2004 07:17:12 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Jul 27 09:17:03 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BpMCt-0005KJ-00 for ; Tue, 27 Jul 2004 09:17:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BpMFx-00027Z-Nf for geh-help-gnu-emacs@m.gmane.org; Tue, 27 Jul 2004 03:20:13 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!newsmi-us.news.garr.it!newsmi-eu.news.garr.it!NewsITBone-GARR!fu-berlin.de!uni-berlin.de!not-for-mail Original-Newsgroups: gnu.emacs.help,comp.lang.lisp Original-Lines: 49 Original-X-Trace: news.uni-berlin.de Asx+cmpQ5KeC4QK7jiXDXAFDswcdNeV2xv9bbfc6nH6ADHVe+O X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Xref: shelby.stanford.edu gnu.emacs.help:124486 comp.lang.lisp:144256 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.help:19822 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:19822 Lowell Kirsh writes: > This still doesn't seem to work. With the following defun and call: > > (defmacro my-add-hooks (hooks &rest body) > `(dolist (hook ',hooks) > (my-add-hook hook ,@body))) > > (my-add-hooks (inferior-lisp lisp emacs-lisp lisp-interaction) > (imenu-add-to-menubar "Symbols")) > > I get the following macroexpansion, which looks correct to me, but > doesn't actually do anything: > > (cl-block-wrapper > (catch (quote --cl-block-nil--) > (let ((--dolist-temp--20870 (quote (inferior-lisp lisp emacs-lisp > lisp-interaction))) > hook) > (while --dolist-temp--20870 > (setq hook (car --dolist-temp--20870)) > (my-add-hook hook > (imenu-add-to-menubar "Symbols")) > (setq --dolist-temp--20870 (cdr --dolist-temp--20870))) > nil))) That's because my-add-hook is a macro, too, and so you just add stuff to hook-mode-hook three times. > > Apart from that, I consider this sort of thing a crock. What are > > you hoping to achieve that you would not be better off doing by a > > proper function instead of a macro? In short, I still consider this sort of thing a crock, since you'd be better off using a function instead of a macro. You are unable to comprehend what your macros do, and it shows. Macros are just not sensible for this sort of thing. Use functions instead. You'll need to use some quotes at the outer level, but you'll understand what happens. To fix the above, you'd need to write something like (defmacro my-add-hooks (hooks &rest body) (dolist (hook hooks) `(my-add-hook ,hook ,@body))) -- David Kastrup, Kriemhildstr. 15, 44793 Bochum