From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Klaus Berndl Newsgroups: gmane.emacs.help Subject: Re: How to use defadvice without infinite loop Date: 28 Sep 2003 07:14:27 +0200 Organization: "sd&m AG, Muenchen, Germany" Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: <87d6dm1d5t.fsf@juliva.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1064726212 15183 80.91.224.253 (28 Sep 2003 05:16:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 28 Sep 2003 05:16:52 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sun Sep 28 07:16:50 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A3TvO-000552-00 for ; Sun, 28 Sep 2003 07:16:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A3TuQ-0002BO-Cu for geh-help-gnu-emacs@m.gmane.org; Sun, 28 Sep 2003 01:15:50 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!logbridge.uoregon.edu!news2.telebyte.nl!nntpfeed-01.ops.asmr-01.energis-idc.net!newsfeed.multikabel.nl!newsfeed.kabelfoon.nl!195.129.110.21.MISMATCH!bnewsfeed00.bru.ops.eu.uu.net!bnewsinpeer00.bru.ops.eu.uu.net!lnewsinpeer01.lnd.ops.eu.uu.net!emea.uu.net!news.sdm.de!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 45 Original-NNTP-Posting-Host: callin11.muc.sdm.de Original-X-Trace: news.sdm.de 1064726068 28366 195.125.139.11 (28 Sep 2003 05:14:28 GMT) Original-X-Complaints-To: usenet@news.sdm.de Original-NNTP-Posting-Date: Sun, 28 Sep 2003 05:14:28 +0000 (UTC) User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 Original-Xref: shelby.stanford.edu gnu.emacs.help:116917 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.help:12843 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:12843 On 27 Sep 2003, Ivan Kanis wrote: > I want to save VM files to _always_ be saved before calling the function > save-some buffers. > > I am tired of answering 'yes' for these files when grepping, compiling > or quiting emacs. > > I came up with a defadvice function but the proble is that it's > calling save-some-buffers and it produces an infinite loop. Is there a > way to avoid that? > > (defadvice save-some-buffers(before my-save-some-buffers activate) > "Ask to save buffers." > (interactive) > (save-some-buffers nil 'my-always-save)) The infinite loop comes because the `save-some-buffers' in your advice calls the adviced version of `save-some-buffers' again and then again and then again.... Normally i should write here: RTFM ;-) You should definitely read the advice info-manual - there are some very simple and helpful examples in it! (defadvice save-some-buffers(before my-save-some-buffers activate) "Ask to save buffers." (ad-set-arg 1 'my-always-save)) This is all...test it! > > (defun my-always-save() > "Files to always save." > (when buffer-file-name > (when (string-match "^/home/ivank/mail" buffer-file-name) > (save-buffer)))) Ciao, Klaus -- Klaus Berndl mailto: klaus.berndl@sdm.de sd&m AG http://www.sdm.de software design & management Thomas-Dehler-Str. 27, 81737 München, Germany Tel +49 89 63812-392, Fax -220