unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Sarir Khamsi <sarir.khamsi@raytheon.com>
To: help-gnu-emacs@gnu.org
Subject: Advice on writing predicates
Date: Thu, 25 Jun 2009 15:27:19 -0700	[thread overview]
Message-ID: <uhby454qg.fsf@raytheon.com> (raw)

I wrote a simple predicate that returns t if the Emacs major version
number is greater than 22 and would like some advice/comments:

The following

(defun sk-emacs-version-greater-than23-p ()
  "Return non-nil if current Emacs version is greater than 22."
  (interactive)
  (setq version-string (replace-regexp-in-string ".*?\\([0-9]+\\)\.\\([0-9]+\\)\.\\([0-9]+\\)[()-.a-zA-Z0-9 \n]+" "\\1 \\2 \\3" (emacs-version)))
  (setq version-num (mapcar 'string-to-number (split-string version-string)))
  (if (> 22 (car version-num))
      t
    nil))

seems to work. I know that I don't need to save \2 and \3 but wanted
that for a later function. Any comments or suggestions on how to make
this better? Thanks.

Sarir

-- 
Sarir Khamsi
software guy
sarir.khamsi@raytheon.com


             reply	other threads:[~2009-06-25 22:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-25 22:27 Sarir Khamsi [this message]
2009-06-25 23:23 ` Advice on writing predicates Anselm Helbig
2009-06-29 19:18   ` chickenphat
2009-06-26  6:40 ` Daniel Pittman
2009-06-26  7:37 ` Andreas Röhler
2009-06-26  9:13 ` Pascal J. Bourguignon
2009-06-26 11:02 ` Thien-Thi Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uhby454qg.fsf@raytheon.com \
    --to=sarir.khamsi@raytheon.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).