defadvice on garbage-collect doesnt work?

defadvice on garbage-collect doesnt work?

[joakim]

I would like to make a little memory meter for emacs on the mode line.

I would like to use the information returned by (garbage-collect) but
it doesnt seem right to do a garbage collect everytime the modeline is
displayed, therefore i would like to store the values calculated by
the last gc in a variable:

in ielm:

(defadvice garbage-collect (around
garbage-collect-advice-store-values) (setq last-gc-value ad-do-it))
(ad-activate 'garbage-collect)

(garbage-collect)
last-gc-value

last-gc-value shows the right values, same as returned by
(garbage-collect). However, when I leave emacs running for a couple of
hours, last-gc-value doesnt change. I interpret this as meaning my
defadvice is ignored when emacs gc:s automatically, but not when
called interacvtively.

Any hints how to achieve this? BTW the use-case I had in mind for the
memory meter was to see what kinds of operations gobbles up memory. I
have trouble with emacs growing slowly over a fortnight until its so
huge it crashes. 


-- 
Joakim Verona

Re: defadvice on garbage-collect doesnt work?

[John Paul Wallington]

joakim@verona.se writes:

> I would like to use the information returned by (garbage-collect) but
> it doesnt seem right to do a garbage collect everytime the modeline is
> displayed, therefore i would like to store the values calculated by
> the last gc in a variable:

How about sticking something to collect information on `post-gc-hook',
the hook run after garbage collection has finished ?

Re: defadvice on garbage-collect doesnt work?

[Tim X]

jpw@pobox.com (John Paul Wallington) writes:

> joakim@verona.se writes:
>
>> I would like to use the information returned by (garbage-collect) but
>> it doesnt seem right to do a garbage collect everytime the modeline is
>> displayed, therefore i would like to store the values calculated by
>> the last gc in a variable:
>
> How about sticking something to collect information on `post-gc-hook',
> the hook run after garbage collection has finished ?

I suspect this would be a better approach. While defadvice is a really great
feature, I've found you can have some issues with it when trying to use it on
very low level functions - mainly those which are based in C source. 

Tim

-- 
tcross (at) rapttech dot com dot au

Re: defadvice on garbage-collect doesnt work?

[Oliver Scholz]

Tim X <timx@nospam.dev.null> writes:

[...]
> I suspect this would be a better approach. While defadvice is a really great
> feature, I've found you can have some issues with it when trying to use it on
> very low level functions - mainly those which are based in C source. 

Defadvices have no effect on built-in functions iff they are called
from C code.


    Oliver
-- 
25 Ventôse an 215 de la Révolution
Liberté, Egalité, Fraternité!

Re: defadvice on garbage-collect doesnt work?

[joakim]

Tim X <timx@nospam.dev.null> writes:

> jpw@pobox.com (John Paul Wallington) writes:
>
>> joakim@verona.se writes:
>>
>>> I would like to use the information returned by (garbage-collect) but
>>> it doesnt seem right to do a garbage collect everytime the modeline is
>>> displayed, therefore i would like to store the values calculated by
>>> the last gc in a variable:
>>
>> How about sticking something to collect information on `post-gc-hook',
>> the hook run after garbage collection has finished ?

That seems nice, but the hook runs after the gc, right? So how can I
acess the returnvalue of the gc from the hook?

> I suspect this would be a better approach. While defadvice is a really great
> feature, I've found you can have some issues with it when trying to use it on
> very low level functions - mainly those which are based in C source. 
>
> Tim
>
> -- 
> tcross (at) rapttech dot com dot au

-- 
Joakim Verona