From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: uzibalqa Newsgroups: gmane.emacs.help Subject: Re: Using button-label in pcase Date: Mon, 24 Jul 2023 22:40:03 +0000 Message-ID: References: <87pm4hvztc.fsf@gmx.net> <87lef5vuzf.fsf@gmx.net> <87h6ptvsxb.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40562"; mail-complaints-to="usenet@ciao.gmane.io" Cc: uzibalqa via Users list for the GNU Emacs text editor To: Stephen Berman Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 25 00:40:58 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qO4Eb-000ALW-3C for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 25 Jul 2023 00:40:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qO4E3-0006ka-9B; Mon, 24 Jul 2023 18:40:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qO4Dz-0006jS-Pf for help-gnu-emacs@gnu.org; Mon, 24 Jul 2023 18:40:20 -0400 Original-Received: from mail-4325.protonmail.ch ([185.70.43.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qO4Dw-0007Yx-5y for help-gnu-emacs@gnu.org; Mon, 24 Jul 2023 18:40:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1690238406; x=1690497606; bh=hov+0iuz/J0JfTaRAysKf570C36Dj+qqmkbeT79VR1w=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mC7TpFn8aku8jV/kJ5oceDHDBGPbE3AESwND83AA1b8ql4XPH5/wwvDL1k0ihEIvE t+YT7VSUrEOAdyYeXk0CWMceWtJeuO4hy7/uP2GtbnSGBgUhRhOqK7T7c95PVnagFb 3Cz7LYgv7GYpIgRwhp/yWG8+ZHVJ53HPhNE0uUi3kqFfU6zN1rnG7RbhhCk9L3avDy ebgYfoFGsG2iI+t3ViZUGRFJHt4a/9iSvZjn/ZAdNO5U6j4is035v0I+yQtZi+KoQb e1vMNw59k8P9ExefYcjyySJTnYlJAcNXCERIdnd24nlpyKeaWVCDk0wEdyF8mV8uJQ pdPyywUwo/ueg== In-Reply-To: <87h6ptvsxb.fsf@gmx.net> Feedback-ID: 52887082:user:proton Received-SPF: pass client-ip=185.70.43.25; envelope-from=uzibalqa@proton.me; helo=mail-4325.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:144432 Archived-At: ------- Original Message ------- On Tuesday, July 25th, 2023 at 10:36 AM, Stephen Berman wrote: > On Mon, 24 Jul 2023 22:24:33 +0000 uzibalqa uzibalqa@proton.me wrote: >=20 > > ------- Original Message ------- > > On Tuesday, July 25th, 2023 at 9:51 AM, Stephen Berman > > stephen.berman@gmx.net wrote: > >=20 > > > On Mon, 24 Jul 2023 21:35:44 +0000 uzibalqa uzibalqa@proton.me wrote: > > >=20 > > > > ------- Original Message ------- > > > > On Tuesday, July 25th, 2023 at 8:07 AM, Stephen Berman > > > > stephen.berman@gmx.net wrote: > > > >=20 > > > > > On Mon, 24 Jul 2023 19:14:27 +0000 uzibalqa uzibalqa@proton.me wr= ote: > > > > >=20 > > > > > > Want to print some text as a result of clicking a button. With = the code below > > > > > > I end up with > > > > > >=20 > > > > > > (wrong-type-argument integer-or-marker-p nil) > > > > > > buffer-substring-no-properties(nil nil) > > > > > > button-label(#) > > > > > > (let* ((val (button-label button))) (if (equal val '"[FA]") (le= t nil > > > > > > (insert qrh-c)))) > > > > > > (closure ((button . #)) nil (let* ((val > > > > > > (button-label button))) (if (equal val '"[FA]") (let nil (inser= t > > > > > > qrh-c)))))() > > > > > > help--window-setup("Help" (closure ((button . #)) > > > > > > nil (let* ((val (button-label button))) (if (equal val '"[FA]")= (let nil > > > > > > (insert qrh-c)))))) > > > > > > qrh-b(#) > > > > > > button-activate(# t) > > > > > > push-button(3 t) > > > > > >=20 > > > > > > What is going on. Is there a fix? > > > > > >=20 > > > > > > (defconst qrh-c "[FA] Some Text") > > > > > >=20 > > > > > > (defun qrh-b (button) > > > > > > "Prints information about how to install emacs." > > > > > > (with-help-window (help-buffer) > > > > > > (pcase (button-label button) > > > > > > ("[FA]" (insert qrh-c))) )) > > > > > >=20 > > > > > > (defun qrh-a () > > > > > > "Prints information about how to install emacs." > > > > > > (interactive) > > > > > > (with-help-window (help-buffer) > > > > > > (insert-button "[FC]" > > > > > > 'action 'qrh-b 'follow-link t) )) > > > > >=20 > > > > > The error is raised because qrh-b calls with-help-window with the= Help > > > > > buffer current, but with-help-window erases the buffer, so when > > > > > `(button-label button)' is evaluated, there is no button and this > > > > > signals the error. > > > >=20 > > > > That what was wrong then. > > >=20 > > > That there was no button. When you execute your command qrh-a and the= n > > > in the resulting Help buffer press the button, it disappears. > > >=20 > > > > > If you want to use the existing Help buffer, just remove the call= to > > > > > with-help-window in qrh-b. > > > >=20 > > > > > However, Help buffers are read-only, so > > > > > trying to insert text will raise another error. To avoid this, yo= u can > > > > > let-bind buffer-read-only in qrh-b. > > > >=20 > > > > I do not experience the problem you mention. What error are you ref= erring to, > > > > and how can it be triggered ? > > >=20 > > > Did you remove the call the with-help-window in qrh-b and correct the > > > match condtion (or change the string in qrh-a to match the one in > > > qrh-b)? If so, then when you press the button in the Help buffer, you > > > will get the error "Buffer is read-only: #". > >=20 > > > Steve Berman > >=20 > > I did the changes and have the following > >=20 > > (pcase (button-label button) > > ("[FA]" > > (with-help-window (help-buffer) ; Print in help buffer > > (insert qrh-c))) >=20 >=20 > Sure, that's a fine way to avoid the problem with the read-only state of > the Help buffer. >=20 > Steve Berman I replicated the error you mentioned though. Why does it happen ? Is that= because the insert would be within an (with-help-window (help-buffer) ?