unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Jim Diamond <Jim.Diamond@deletethis.AcadiaU.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: 24.1.50 + lexical-binding + server.el + server-visit-hook = problem
Date: Tue, 26 Jun 2012 13:15:59 -0300	[thread overview]
Message-ID: <slrnjujo1v.7r5.Jim.Diamond@tux.acadiau.ca> (raw)
In-Reply-To: jwvobo79f2b.fsf-monnier+gnu.emacs.help@gnu.org

On 2012-06-25 at 20:03 ADT, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>>>> Thanks for your thoughts.  Given the lack of discussion in this
>>>> thread, I get the idea I'm the only person doing anything like this.
>>> Maybe, but I'd still accept a patch that makes it easier,
>> When you say "I'd accept a patch", does that mean you are willing to
>> put such a thing in, assuming the patch is OK?
> Yes.
Great.

>> If so, how about this diff against the server.el from 24.1:
>> diff server.el.orig server.el      
>> 1131c1131,1133
>> <                  (setq dir (command-line-normalize-file-name dir)))
>> ---
>> > (setq dir (command-line-normalize-file-name dir))
>> > (process-put proc 'emacsclient-cwd dir)
>> > )
>
> "diff -u" is a better choice for output format, but thanks.
I figured I should use another incantation of diff, but given the lack
of extensiveness, I figured that might do.

> The patch looks good, I installed it in Emacs's trunk.
Thanks very much.

>> In my tests, that does what I want.  I'm not in love with the name
>> "emacsclient-cwd", so if there is something which is seen as a better
>> name, that's find with me.
> I've changed it to `server-client-directory' (the "server-" part is
> just a kind of "module name prefix").
Sounds fine.

Thanks for your help with this.

				Jim


      reply	other threads:[~2012-06-26 16:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 18:48 24.1.50 + lexical-binding + server.el + server-visit-hook = problem Jim Diamond
2012-06-05  4:11 ` Kevin Rodgers
     [not found] ` <mailman.2291.1338869494.855.help-gnu-emacs@gnu.org>
2012-06-05 11:21   ` Jim Diamond
2012-06-06  1:17 ` Stefan Monnier
2012-06-06 20:01   ` Jim Diamond
2012-06-07  3:42     ` Kevin Rodgers
     [not found]     ` <mailman.2373.1339040551.855.help-gnu-emacs@gnu.org>
2012-06-09 14:33       ` Jim Diamond
2012-06-11 13:27       ` Stefan Monnier
2012-06-11 14:33         ` Jim Diamond
2012-06-13 15:13           ` Stefan Monnier
2012-06-24 20:34             ` Jim Diamond
2012-06-25 23:03               ` Stefan Monnier
2012-06-26 16:15                 ` Jim Diamond [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrnjujo1v.7r5.Jim.Diamond@tux.acadiau.ca \
    --to=jim.diamond@deletethis.acadiau.ca \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).