unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Yang Zhang" <fz15@cse.msstate.edu>
Cc: help-gnu-emacs@gnu.org
Subject: Re: tramp 2.1.13-pre messed up symbolic link?
Date: Wed, 25 Jun 2008 13:35:35 +0200	[thread overview]
Message-ID: <nqzlp9d9x4.fsf@alcatel-lucent.de> (raw)
In-Reply-To: <8d61170c0806232224r324a4b0gb1f22fa28ac78e36@mail.gmail.com> (Yang Zhang's message of "Tue, 24 Jun 2008 00:24:06 -0500")

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

"Yang Zhang" <fz15@cse.msstate.edu> writes:

> Hi Michael,

Hi Yang,

> There is one small issue (that I've noticed for a long time). After
> saving, the target file's permission is always set to be "-rwxrwxrwx"
> regardless of the original one. For example, the target file is
> "test.cc (-rw-------)" the symbolic link is "test_link.cc (always
> lrwxrwxrwx)"  After opening "test_link.cc" through tramp and saving
> something, "test.cc" now has a permission of "-rwxrwxrwx".  It there a
> way to retain the target file's original permission after saving
> through the symbolic link file?

Please try the appended patch. It should fix it.

> Thanks
> --Yang

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 836 bytes --]

*** /tmp/tramp.el	Wed Jun 25 13:32:11 2008
--- /tmp/tramp.el.~1~	Wed Jun 25 13:32:11 2008
***************
*** 2675,2684 ****
  
  (defun tramp-handle-file-modes (filename)
    "Like `file-modes' for Tramp files."
!   (let ((truename (or (file-truename filename) filename)))
!     (when (and (stringp truename) (file-exists-p truename))
!       (tramp-mode-string-to-int
!        (nth 8 (file-attributes truename))))))
  
  (defun tramp-handle-file-directory-p (filename)
    "Like `file-directory-p' for Tramp files."
--- 2675,2683 ----
  
  (defun tramp-handle-file-modes (filename)
    "Like `file-modes' for Tramp files."
!   (when (file-exists-p filename)
!     (tramp-mode-string-to-int
!      (nth 8 (file-attributes filename)))))
  
  (defun tramp-handle-file-directory-p (filename)
    "Like `file-directory-p' for Tramp files."

  parent reply	other threads:[~2008-06-25 11:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19  7:56 tramp 2.1.13-pre messed up symbolic link? Yang Zhang
2008-06-19 10:19 ` Peter Dyballa
     [not found] ` <mailman.13566.1213870789.18990.help-gnu-emacs@gnu.org>
2008-06-20  4:50   ` Yang Zhang
2008-06-21  8:37     ` Michael Albinus
     [not found]       ` <8d61170c0806220203h75885df3nf6283e13c6d3732c@mail.gmail.com>
2008-06-23 10:26         ` Michael Albinus
2008-06-24  5:24           ` Yang Zhang
2008-06-24 15:10             ` Michael Albinus
2008-06-25 11:35             ` Michael Albinus [this message]
2008-06-26  4:31               ` Yang Zhang
     [not found]             ` <mailman.13825.1214393802.18990.help-gnu-emacs@gnu.org>
2008-06-26 17:20               ` Thr4wn
2008-06-26 20:43                 ` Yang Zhang
2008-06-27  7:05                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nqzlp9d9x4.fsf@alcatel-lucent.de \
    --to=michael.albinus@gmx.de \
    --cc=fz15@cse.msstate.edu \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).