From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.help Subject: Re: magit attempting to use external editor (!) for commit Date: Mon, 12 Oct 2020 19:19:43 +0200 Message-ID: References: <87y2kbpehm.fsf@ucl.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: Eric S Fraga Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 12 19:20:16 2020 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kS1Ue-0005yU-Dh for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Oct 2020 19:20:16 +0200 Original-Received: from localhost ([::1]:59972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1Ud-0005Ky-GE for geh-help-gnu-emacs@m.gmane-mx.org; Mon, 12 Oct 2020 13:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1UC-0005JB-Rb for help-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:19:48 -0400 Original-Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:39569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1UA-0003ym-QP for help-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:19:48 -0400 Original-Received: by mail-wm1-x344.google.com with SMTP id d3so18270707wma.4 for ; Mon, 12 Oct 2020 10:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=1uV8zno5tk1sL6t3gQRGswCnHfFXfbIS/hzg2P9Y424=; b=r5twwNl79ExFmSqyk5HMQc2PfmOLpKGsboIo9l3zxDD0SXEQQ4pmik2ryCERsG/UJx QlVRVS69A4EXnY1hZwdVstgeDC94zYNuKRxpz/3lb6Rwv5YpzWnhtMNS+yTP5t8YJKwJ JxrIEssXs2+bldIwkj3jMvf9VNyaCfMOhniCLq3grUjUoTZLw8KDfMkXGlRrLkY7zaIF Xhb1iprB0N8SGOCGjwf10cgLLocysnDCBvYMrYsZPms9pxBi3iSs/+Alu7UIGP5CRJ6l lHJRCkoX92lnlpUiFgrj4L/YthLqHnCG6CN6liqbbCQdqC0fLm+CC4iLzRCCI8Fvxv+e wIzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=1uV8zno5tk1sL6t3gQRGswCnHfFXfbIS/hzg2P9Y424=; b=ZzCT7396wHkAz7MWlCezpS4z+4MfEYmZ4YcLwngn/S7eB3nsd727Kcs5vSA29m0bNL oYfA3aphy1wxvimJz9Ew7nYYEMZcdNT6qR9Kd9u/nGf1x3AQXO6fnFHLUgRsV7XSuE/w OMpZMt32GSvW6FhsGjSLFORaGzHAUXbVsHDh+oZqIRikv5638SLp/++W0B5ss47WgzvU BTY76sUnvJapA+agCS3F2FlVKNBt7tibwKpwmub11uQ5lptelOeaTio3bMLoUS2MVT0P MPlxd/u72gkm9nswOf24Mo9ip2wFvkppfL2K5ovjds961vuRjmvHjNxJiEzKmB5me5ZJ ohzA== X-Gm-Message-State: AOAM530yvsQpB3y1J2/LliKuVOUVDO4YE8lAYUJK8j4lGh267TX+gR/5 wsMOwUyuzgVEPYykdS8q7KdXnrRkSq8u8w== X-Google-Smtp-Source: ABdhPJxW3dF+kHI+66DgzwlFgKs3+RE5N4hpYiKabAE22VJIIXaSmT/VUH6B7pgmoHrUR3qQB4JkhQ== X-Received: by 2002:a05:600c:230a:: with SMTP id 10mr12145623wmo.151.1602523184822; Mon, 12 Oct 2020 10:19:44 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:2989:6e8d:76df:f4ec]) by smtp.gmail.com with ESMTPSA id d4sm25638129wrp.47.2020.10.12.10.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 10:19:44 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <87y2kbpehm.fsf@ucl.ac.uk> (Eric S. Fraga's message of "Mon, 12 Oct 2020 17:59:17 +0100") Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=rpluim@gmail.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:124441 Archived-At: >>>>> On Mon, 12 Oct 2020 17:59:17 +0100, Eric S Fraga = said: Eric> Hello all, Eric> For some reason, starting today, after updating Emacs from git, w= hen I Eric> try to commit a change using magit, it tries to start up emacscli= ent Eric> (maybe based on my EDITOR environment variable?). It actually fa= ils Eric> whether I've started the server or not. First of all, why would = magit Eric> want to do this given that I'm in Emacs already? Has it always d= one Eric> this? Secondaly, what is it that I have done (or not done) to en= d up in Eric> this situation? - Because it=CA=BCs providing the commit message to git using git's external editor support, which then needs to call back into emacs - Yes - The interface to emacsclient changed in emacs, which means the with-editor package needed to be adjusted. See and TL;DR update your with-editor package Eric> I have reverted to using vc-* commands for the time being so I ca= n keep Eric> working but I do like using magit for selective commits. I feel your pain Robert --=20