From: Robert Pluim <rpluim@gmail.com>
To: Eric S Fraga <e.fraga@ucl.ac.uk>
Cc: help-gnu-emacs@gnu.org
Subject: Re: magit attempting to use external editor (!) for commit
Date: Mon, 12 Oct 2020 19:19:43 +0200 [thread overview]
Message-ID: <m2imbf2wgg.fsf@gmail.com> (raw)
In-Reply-To: <87y2kbpehm.fsf@ucl.ac.uk> (Eric S. Fraga's message of "Mon, 12 Oct 2020 17:59:17 +0100")
>>>>> On Mon, 12 Oct 2020 17:59:17 +0100, Eric S Fraga <e.fraga@ucl.ac.uk> said:
Eric> Hello all,
Eric> For some reason, starting today, after updating Emacs from git, when I
Eric> try to commit a change using magit, it tries to start up emacsclient
Eric> (maybe based on my EDITOR environment variable?). It actually fails
Eric> whether I've started the server or not. First of all, why would magit
Eric> want to do this given that I'm in Emacs already? Has it always done
Eric> this? Secondaly, what is it that I have done (or not done) to end up in
Eric> this situation?
- Because itʼs providing the commit message to git using git's
external editor support, which then needs to call back into emacs
- Yes
- The interface to emacsclient changed in emacs, which means the
with-editor package needed to be adjusted. See
<https://github.com/magit/with-editor/issues/82>
and <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=43716>
TL;DR update your with-editor package
Eric> I have reverted to using vc-* commands for the time being so I can keep
Eric> working but I do like using magit for selective commits.
I feel your pain
Robert
--
next prev parent reply other threads:[~2020-10-12 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:59 magit attempting to use external editor (!) for commit Eric S Fraga
2020-10-12 17:19 ` Robert Pluim [this message]
2020-10-13 7:24 ` Eric S Fraga
2020-10-13 15:00 ` Óscar Fuentes
2020-10-14 9:16 ` Eric S Fraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2imbf2wgg.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=e.fraga@ucl.ac.uk \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).