From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: minor-mode hook not run Date: Tue, 20 Mar 2018 16:31:53 -0400 Message-ID: References: <2c3c91da-0f8e-cad2-1746-b3f7a66da98d@easy-emacs.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521577869 22228 195.159.176.226 (20 Mar 2018 20:31:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 20:31:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Tue Mar 20 21:31:05 2018 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyNuO-0005a4-ML for geh-help-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 21:31:00 +0100 Original-Received: from localhost ([::1]:51622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyNwR-0008Rt-Us for geh-help-gnu-emacs@m.gmane.org; Tue, 20 Mar 2018 16:33:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyNvh-0008Q1-HV for help-gnu-emacs@gnu.org; Tue, 20 Mar 2018 16:32:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyNvd-0005gg-Jk for help-gnu-emacs@gnu.org; Tue, 20 Mar 2018 16:32:21 -0400 Original-Received: from [195.159.176.226] (port=41777 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyNvd-0005fu-Cx for help-gnu-emacs@gnu.org; Tue, 20 Mar 2018 16:32:17 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eyNtX-0004fD-7z for help-gnu-emacs@gnu.org; Tue, 20 Mar 2018 21:30:07 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:xNpGRqq+iiOEVjSkpK6uxhTtJv8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.org gmane.emacs.help:116217 Archived-At: > (define-minor-mode foo ^^^ This should likely be `foo-mode`. > "Do something" nil " FOO"} Is the above } intended? > :keymap foo-map [ I strongly recommend not to use :keymap argument and just name your minor mode map `-map`. ] > (cond > ((eq major-mode 'abc) It's usually better to test (derived-mode-p 'abc). > (add-hook 'foo-mode-hook 'foo-load-abc nil t) Adding elements to one's own hook here definitely deserve a "bug ugly hack" comment explaining why you'd want to do it that way. In any case, the minor mode `foo` will run `foo-hook` but not `foo-mode-hook` (which would be run by the `foo-mode` minor mode). Stefan