From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Run terminal command with output in current buffer Date: Fri, 16 Jul 2021 12:36:49 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31219"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:ZxSJqIaTuwER7/M26k4z8Qo1gOM= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 16 18:37:44 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m4QqO-00082l-KY for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 18:37:44 +0200 Original-Received: from localhost ([::1]:51886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4QqN-0000go-LZ for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 16 Jul 2021 12:37:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Qpg-0000ef-7y for help-gnu-emacs@gnu.org; Fri, 16 Jul 2021 12:37:00 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:57250) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4Qpe-0001P6-IK for help-gnu-emacs@gnu.org; Fri, 16 Jul 2021 12:37:00 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1m4Qpc-00078O-DR for help-gnu-emacs@gnu.org; Fri, 16 Jul 2021 18:36:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:131762 Archived-At: > (let ( (cmd-excl (read-from-minibuffer "exclude: ")) > (cmd-incl (read-from-minibuffer "include: ")) > (cmd-cnum (read-from-minibuffer "cnum: ")) > (cmd-ptrn (read-from-minibuffer "pattern: ")) > (cmd-dpth (read-from-minibuffer "dpth: ")) > cmd ) > > (setq cmd-excl (concat " --exclude=\\*." cmd-excl)) > (setq cmd-incl (concat " --include=\\*." cmd-incl)) > (setq cmd-cnum (concat " -C " cmd-cnum)) > > (setq cmd (concat "grep -hir" cmd-excl cmd-incl > cmd-cnum " " cmd-ptrn " " cmd-dpth)) > (message "%s" cmd) > (shell-command cmd (current-buffer))) ) I'd probably write this as something like: (let* ((cmd-excl (concat "--exclude=*." (read-string "exclude: "))) (cmd-incl (concat "--include=*." (read-string "include: "))) (cmd-cnum (read-string "cnum: ")) (cmd-ptrn (read-string "pattern: ")) (cmd-dpth (read-string "dpth: ")) (cmd1 `("grep" "-hir" ,cmd-excl ,cmd-incl "-C" ,cmd-cnum ,cmd-ptrn)) (cmd (concat (mapconcat #'shell-quote-argument cmd1 " ") " " cmd-depth))) (message "%s %s" cmd) (shell-command cmd (current-buffer))) ) Note the use of `read-string` (`read-from-minibuffer` is a low-level function used to implement `read-string`, `read-number`, `read-buffer`, `completing-read`, ...) and the use of `shell-quote-argument` to deal with quoting those parts that need it. I presumed that "dpth" is supposed to be a glob pattern, which is the only place where you actually need the shell. You could also use `file-expand-wildcards` instead so you don't need a shell at all (and hence don't need `shell-quote-argument` either) and can use `call-process` instead of `shell-command` which stops you from worrying about what happens if the users put a `|`, `;`, `$(cmd)`, or other fun stuff in dpth. Stefan