Re: condition-case

Re: condition-case

[Ted Zlatanov]

On Thu, 09 Dec 2010 10:04:12 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>> Here's what Pascal posted originally.
SM> The code looks fine (tho it needs a reindent to follow Elisp
SM> convention).  The docstring needs a completely rewrite, OTOH, to follow
SM> Elisp convention: first line should succintly describe the macro, and
SM> the rest should give details about what it does and what each
SM> param means.  I.e. someone not familiar with Common-Lisp should be able
SM> to understand how to use it.

Yes, that's not hard.  I was worried about the code's behavior.

>> (subst  var (car clausvar) body)))))

SM> Oh wait, I just noticed this one: `subst' is wrong here.  I know CL
SM> already uses it for similar purposes elsewhere, but it's simply wrong
SM> because `subst' doesn't know about Elisp binding rules.
SM> So (subst 'b 'a '(lambda () '(a b c))) will happily return
SM> (lambda () '(b b c)).  Better simply use `let', even if it has
SM> a performance cost.

I didn't catch that.  I don't know enough about ELisp vs. CL scoping and
binding rules to write this properly, unfortunately.  Can you show how
`let' could be used?  I'll take the code and provide the doc string and
reindent it, then propose the revised version in emacs-devel.

On Thu, 09 Dec 2010 05:34:02 +0100 "Pascal J. Bourguignon" <pjb@informatimago.com> wrote: 

PJB> Ted Zlatanov <tzz@lifelogs.com> writes:

>> Here's what Pascal posted originally.  I tested it a little and it seems
>> to work OK; it's basically syntactic sugar but pretty pleasant.  We
>> should also consider `handler-bind' which is like `handler-case' but
>> executes handlers directly.  Pascal, do you have an implementation of
>> that as well?

PJB> There's no condition-bind to wrap over.

PJB> I'm not sure it would be possible to implement handler-bind without
PJB> patching the virtual machine.

Stefan, WDYT?  Is `condition-bind' possible in today's GNU Emacs?  I
mean does the VM have any constraints that would block it?

Ted

Re: condition-case

[Stefan Monnier]

PJB> There's no condition-bind to wrap over.
PJB> I'm not sure it would be possible to implement handler-bind without
PJB> patching the virtual machine.
> Stefan, WDYT?  Is `condition-bind' possible in today's GNU Emacs?  I
> mean does the VM have any constraints that would block it?

There used to be some allowance made in the C code for such a feature,
but since it was never used it bit-rotted and has "recently" been more
actively removed.  So adding a condition-bind or something like that
would require a fair bit of work, I think.  There is still some support
for part of it since errors can jump into the debugger, but currently
the debugger cannot return to the source of the error, it can only jump
back up the stack like condition-case does.


        Stefan

Re: condition-case

[Ted Zlatanov]

On Fri, 10 Dec 2010 16:43:46 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

PJB> There's no condition-bind to wrap over.
PJB> I'm not sure it would be possible to implement handler-bind without
PJB> patching the virtual machine.
>> Stefan, WDYT?  Is `condition-bind' possible in today's GNU Emacs?  I
>> mean does the VM have any constraints that would block it?

SM> There used to be some allowance made in the C code for such a feature,
SM> but since it was never used it bit-rotted and has "recently" been more
SM> actively removed.  So adding a condition-bind or something like that
SM> would require a fair bit of work, I think.  There is still some support
SM> for part of it since errors can jump into the debugger, but currently
SM> the debugger cannot return to the source of the error, it can only jump
SM> back up the stack like condition-case does.

I also notice no one has complained in the last few years that
`condition-case' is insufficient.  So maybe `condition-bind' is simply
not necessary.

Ted

Re: condition-case

[Ted Zlatanov]

On Fri, 10 Dec 2010 12:40:06 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Thu, 09 Dec 2010 10:04:12 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>>> (subst  var (car clausvar) body)))))

SM> Oh wait, I just noticed this one: `subst' is wrong here.  I know CL
SM> already uses it for similar purposes elsewhere, but it's simply wrong
SM> because `subst' doesn't know about Elisp binding rules.
SM> So (subst 'b 'a '(lambda () '(a b c))) will happily return
SM> (lambda () '(b b c)).  Better simply use `let', even if it has
SM> a performance cost.

TZ> I didn't catch that.  I don't know enough about ELisp vs. CL scoping and
TZ> binding rules to write this properly, unfortunately.  Can you show how
TZ> `let' could be used?  I'll take the code and provide the doc string and
TZ> reindent it, then propose the revised version in emacs-devel.

...in other words, in the example you showed, is it just

(let ((b a))
  (lambda () '(b b c)))

or is it more complicated?

Ted

Re: condition-case

[Stefan Monnier]

> ...in other words, in the example you showed, is it just

> (let ((b a))
>   (lambda () '(b b c)))

Yes.  I.e. let the interpreter perform the substitution, at run-time.


        Stefan

Re: condition-case

[Ted Zlatanov]

On Tue, 14 Dec 2010 23:55:45 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>> ...in other words, in the example you showed, is it just
>> (let ((b a))
>> (lambda () '(b b c)))

SM> Yes.  I.e. let the interpreter perform the substitution, at run-time.

OK, so would it work as:

(defmacro handler-case (expression &rest clauses)
  "Evaluate expression with `condition-case' and catch errors with CLAUSES.

Longer explanation here..."
  (let* ((var (gensym))
         (neclause (assoc :NO-ERROR clauses))
         (nell     (cadr neclause))
         (nebody   (cddr neclause))
         (handlers (mapcar (lambda (clause)
                             (let ((typespec (car clause))
                                   (clausvar (cadr clause))
                                   (body     (cddr clause)))
                               (cons (if (and (consp typespec)
                                              (eq 'or (car typespec)))
                                         (cdr typespec)
                                       typespec)
                                     (if (null clausvar)
                                         body
                                       (let ((var (car clausvar)))
                                         body)))))
                           (remove neclause clauses))))
    (if neclause
        `(condition-case ,var
             (multiple-value-bind ,nell ,expression ,@nebody)
           ,@handlers)
      `(condition-case ,var
           ,expression
         ,@handlers))))

Does that new `let' that pops the clause need to evaluated?  And should
it maybe be a `lexical-let'?

Ted

Re: condition-case

[Stefan Monnier]

> OK, so would it work as:

> (defmacro handler-case (expression &rest clauses)
>   "Evaluate expression with `condition-case' and catch errors with CLAUSES.

> Longer explanation here..."
>   (let* ((var (gensym))
>          (neclause (assoc :NO-ERROR clauses))
>          (nell     (cadr neclause))
>          (nebody   (cddr neclause))
>          (handlers (mapcar (lambda (clause)
>                              (let ((typespec (car clause))
>                                    (clausvar (cadr clause))
>                                    (body     (cddr clause)))
>                                (cons (if (and (consp typespec)
>                                               (eq 'or (car typespec)))
>                                          (cdr typespec)
>                                        typespec)
>                                      (if (null clausvar)
>                                          body
>                                        (let ((var (car clausvar)))
>                                          body)))))

You need backquotes around the let.

> Does that new `let' that pops the clause need to evaluated?  And should
> it maybe be a `lexical-let'?

Whether it should be lexical or not is up to you.


        Stefan