From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Defining minor mode with minor-mode condition Date: Tue, 04 May 2021 08:52:40 -0400 Message-ID: References: <87lf8v560d.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:3gGVxroTbGMiXaET0+f0KUUJTfY= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 04 14:53:29 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lduYK-0004uK-QW for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 14:53:28 +0200 Original-Received: from localhost ([::1]:33728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lduYJ-0008KO-Sy for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 04 May 2021 08:53:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lduXf-0008IS-Un for help-gnu-emacs@gnu.org; Tue, 04 May 2021 08:52:47 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]:42172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lduXe-0005XO-E3 for help-gnu-emacs@gnu.org; Tue, 04 May 2021 08:52:47 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lduXc-00045P-Kn for help-gnu-emacs@gnu.org; Tue, 04 May 2021 14:52:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:129422 Archived-At: > ;;;###autoload > (define-minor-mode crucibulum-minor-mode > "Minor mode for assisting with superior & inferior typeface." > :init-value nil > :global nil > :lighter " Crucibulum" > > (if crucibulum-minor-mode > (progn > (enable-texcom-typeface) > (enable-ricci-notation)) > (disable-texcom-typeface) > (disable-ricci-notation))) [ Of course those `:foo nil` keyword arguments are redundant. ] I actually often find it convenient to unconditionally "disable" first: (define-minor-mode crucibulum-minor-mode "Minor mode for assisting with superior & inferior typeface." :lighter " Crucibulum" (disable-texcom-typeface) (disable-ricci-notation) (when crucibulum-minor-mode (enable-texcom-typeface) (enable-ricci-notation))) the advantage is to avoid problems where, say, `enable-texcom-typeface` is not idempotent, so if you call (crucibulum-minor-mode 1) several times you might end up with multiple copies of the same thing added to a list. Stefan