From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: de-dynamicizing some code Date: Wed, 19 Nov 2014 22:57:29 -0500 Message-ID: References: <87h9xuv8q4.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416455898 13775 80.91.229.3 (20 Nov 2014 03:58:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2014 03:58:18 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Thu Nov 20 04:58:11 2014 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrIsj-0007Yz-CG for geh-help-gnu-emacs@m.gmane.org; Thu, 20 Nov 2014 04:58:09 +0100 Original-Received: from localhost ([::1]:33433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrIsi-0007Gp-TX for geh-help-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 22:58:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrIsQ-0007AX-VZ for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 22:57:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrIsJ-0007gM-GZ for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 22:57:50 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:39152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrIsJ-0007g6-9k for help-gnu-emacs@gnu.org; Wed, 19 Nov 2014 22:57:43 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XrIsH-0007R1-2x for help-gnu-emacs@gnu.org; Thu, 20 Nov 2014 04:57:41 +0100 Original-Received: from 167-88-26-132.cpe.teksavvy.com ([167.88.26.132]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 Nov 2014 04:57:41 +0100 Original-Received: from monnier by 167-88-26-132.cpe.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 Nov 2014 04:57:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 167-88-26-132.cpe.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:ArUbDM2YI70ubExsqTnghuyLs4E= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:101068 Archived-At: > I assume the proper solution is to replace this: > (funcall formatfun record) > with: > (funcall formatfun record indent fmt) > Is that correct? There are various solutions, but this one looks like a very good option, indeed. The next best thing is to rename the variables to bbdb-fmt and bbdb-indent (and to add "(defvar bbdb-indent) (defvar bbdb-fmt)" somewhere at top-level (to tell the compiler that these vars should use dynamic binding). Stefan